Skip to content

Conversation

jeffabailey
Copy link
Contributor

@jeffabailey jeffabailey commented Sep 26, 2025

chore: add inputs from ISPO WG to Require InnerSource before Open Source

This PR is brought to you by the ISPO WG: https://docs.google.com/document/d/1Jh7Ig5cjXjyH0URdeZjKTtd89tz9wIxgoFZwp_vCKSY/edit?tab=t.0

chore: add inputs from ISPO WG to Require InnerSource before Open Source
@jeffabailey jeffabailey added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 💻 AI-generated Experiments with generating drafts of patterns with the help of our robot friends :) labels Sep 26, 2025
@spier
Copy link
Member

spier commented Sep 28, 2025

I used the opportunity to write a GitHub workflow that checks if all patterns are listed in README.md
(took me a while to find these docs about how to write useful job summary)

@jeffabailey the new workflow is called Overview Compete so far. Do you have a more helpful (but short) idea for naming this workflow?

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these are just initial patterns, we can merge them basically as is. We can harden them further once we find (multiple) orgs that have adopted this.

Left some inline comments below.

@spier spier moved this to Waiting for Author in Patterns Work Sep 28, 2025
@jeffabailey
Copy link
Contributor Author

I used the opportunity to write a GitHub workflow that checks if all patterns are listed in README.md (took me a while to find these docs about how to write useful job summary)

@jeffabailey the new workflow is called Overview Compete so far. Do you have a more helpful (but short) idea for naming this workflow?

I used the opportunity to write a GitHub workflow that checks if all patterns are listed in README.md (took me a while to find these docs about how to write useful job summary)

@jeffabailey the new workflow is called Overview Compete so far. Do you have a more helpful (but short) idea for naming this workflow?

Overview Complete works, but "Ensure All Patterns Are Listed in README" may be a more direct name, or "Validate Pattern Index in README".

refactor: adjust patlet to 2 sentence problem solution
feat: add references to open source project guidance
refactor: adjust problem to be more specific
…:jeffabailey/InnerSourcePatterns into migrating-from-innersource-to-opensource
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new InnerSource pattern documenting the migration process from InnerSource to Open Source, enhancing the existing "Require InnerSource before Open Source" pattern with additional context and considerations from the ISPO Working Group.

  • Adds a comprehensive new pattern "Migrating from InnerSource to Open Source" with detailed migration steps and considerations
  • Updates the existing "innersource-before-open-source.md" pattern with regulatory, legal, and bidirectional movement considerations
  • Includes a GitHub workflow to ensure all patterns are properly documented in the README

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
patterns/1-initial/migrating-from-innersource-to-open-source.md New pattern providing structured guidance for transitioning InnerSource projects to open source
patterns/1-initial/innersource-before-open-source.md Enhanced with regulatory compliance, IP risk, and OSPO review considerations
README.md Added reference to the new migration pattern
.github/workflows/overview-complete.yml New workflow to validate all patterns are documented in README

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@spier
Copy link
Member

spier commented Sep 29, 2025

Overview Complete works, but "Ensure All Patterns Are Listed in README" may be a more direct name, or "Validate Pattern Index in README".

I was trying to find a shorter name, like the other ones. Probably it is hard to get it to be both short and descriptive at the same time :)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@spier spier merged commit d72063d into InnerSourceCommons:main Sep 30, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Waiting for Author to Done in Patterns Work Sep 30, 2025
@spier
Copy link
Member

spier commented Sep 30, 2025

@jeffabailey this is now live in the repo. Thank you for pushing the work of the ISPO WG into this repo and with that making the content available for the broader community ❤️🥳

Btw the Copilot suggestions on this PR were not super helpful in this particular case, and I ended up rejecting most of them.

@jeffabailey
Copy link
Contributor Author

@jeffabailey this is now live in the repo. Thank you for pushing the work of the ISPO WG into this repo and with that making the content available for the broader community ❤️🥳

Btw the Copilot suggestions on this PR were not super helpful in this particular case, and I ended up rejecting most of them.

I noticed the same. It was way off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 💻 AI-generated Experiments with generating drafts of patterns with the help of our robot friends :)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants