feat: review docker configuration for ActiveMQ stack#342
Open
EmmanuelDemey wants to merge 24 commits intodevelopfrom
Open
feat: review docker configuration for ActiveMQ stack#342EmmanuelDemey wants to merge 24 commits intodevelopfrom
EmmanuelDemey wants to merge 24 commits intodevelopfrom
Conversation
|
aitkarra
reviewed
Dec 4, 2025
davdarras
reviewed
Dec 5, 2025
...ation/src/main/java/fr/insee/queen/application/configuration/LiquibaseContextCustomizer.java
Outdated
Show resolved
Hide resolved
.../java/fr/insee/queen/application/configuration/InboxTableCreatedWhenConsumerEnabledTest.java
Outdated
Show resolved
Hide resolved
aitkarra
reviewed
Dec 5, 2025
| @@ -1,52 +1,44 @@ | |||
| services: | |||
Collaborator
There was a problem hiding this comment.
This duplicates the JMS module component
Collaborator
There was a problem hiding this comment.
Perhaps the JMS component/service could be kept in a single module ?
davdarras
requested changes
Jan 15, 2026
Contributor
davdarras
left a comment
davdarras
left a comment
There was a problem hiding this comment.
- Cannot launch the app. There seems to be some issues with compose and DockerFile when building.
- APIs tests are not working (SQL data issues)
- liquibase contexts are not loaded automatically (as stated in the documentation)
queen-listener-jms/src/main/java/fr/insee/queen/jms/service/OutboxScheduler.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.