Skip to content

RXR-3044: remove ... from PKPDmap::get_map_estimates() calls #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mccarthy-m-g wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

RXR-3044: remove ... from PKPDmap::get_map_estimates() calls #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f6844
add `.Rproj` file
mccarthy-m-g Mar 18, 2026
048aa02
update roxygen version
mccarthy-m-g Mar 18, 2026
2f54dab
remove `...` from `PKPDmap::get_map_estimates()` calls
mccarthy-m-g Mar 18, 2026
c1d2f35
update documentation
mccarthy-m-g Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Description: Functions for simulating dose adjustments given PKPD models,
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
RoxygenNote: 7.3.3
Suggests:
dplyr,
ggplot2,
Expand Down
6 changes: 2 additions & 4 deletions R/map_adjust_dose.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
#' @inheritParams dose_grid_search
#' @param settings list of arguments to be used in dose update, e.g.
#' `dose_resolution`.
#' @param ... arguments passed on to PKPDmap::get_map_estimates and/or
#' PKPDsim::sim
#' @param ... arguments passed on to [PKPDsim::sim] via `dose_grid_search`
#' @returns Returns a named list: `regimen`: the updated regimen;
#' `additional_info`: the MAP parameter estimates
#' @export
Expand All @@ -37,8 +36,7 @@ map_adjust_dose <- function(
ruv = ruv,
tdms = tdms,
covariates = covariates,
regimen = regimen,
...
regimen = regimen
)
if(! all(c("parameters", "pred", "ipred", "dv", "weights") %in% names(fit))) {
cli::cli_warn("Fit error, please investigate. Continuing but using population estimates.")
Expand Down
7 changes: 2 additions & 5 deletions R/map_fit.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#' @param tdms observations to be included in MAP estimates
#' @param covariates named list of PKPDsim covariates
#' @param regimen PKPDsim regimen object
#' @param ... arguments passed on to PKPDmap::get_map_estimates
#' @returns named list of individual PK parameter estimates
#' @export

Expand All @@ -26,8 +25,7 @@ simulate_fit <- function(
ruv,
tdms,
covariates,
regimen,
...
regimen
){
iov_obj <- get_iov_specification(est_model, parameters, omega)

Expand All @@ -45,8 +43,7 @@ simulate_fit <- function(
fixed = iov_obj$fixed,
verbose = FALSE,
skip_hessian = TRUE, # faster
int_step_size = 0.01,
...
int_step_size = 0.01
)},
error = function(e) list(parameters = NULL)
)
Expand Down
3 changes: 1 addition & 2 deletions man/map_adjust_dose.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions man/map_adjust_interval.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/simulate_fit.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions mipdtrial.Rproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Version: 1.0
Copy link
Copy Markdown
Collaborator

@jasmineirx jasmineirx Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to commit this file? i notice this had not yet been added

Copy link
Copy Markdown
Contributor Author

@mccarthy-m-g mccarthy-m-g Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? That's why I added it. Not sure if it was never there or got accidentally deleted at some point

Copy link
Copy Markdown
Contributor Author

@mccarthy-m-g mccarthy-m-g Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we accidentally removed it here: https://github.com/InsightRX/mipdtrial/pull/26/changes


RestoreWorkspace: Default
SaveWorkspace: Default
AlwaysSaveHistory: Default

EnableCodeIndexing: Yes
UseSpacesForTab: Yes
NumSpacesForTab: 2
Encoding: UTF-8

RnwWeave: Sweave
LaTeX: pdfLaTeX

BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source
PackageRoxygenize: rd,collate,namespace
Loading