-
Notifications
You must be signed in to change notification settings - Fork 31
Add implicit NumPy conversion for dpctl.tensor.usm_ndarray types #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ndgrigorian I am unable to check the jenkins CI checks. Is there any way someone from your team can help me? |
I can help with that, but there are still concerns with this PR that need to be addressed, some of which I mentioned in the issue If this PR were modified to accept an environment variable to permit implicit conversion, that would be acceptable, but implicit conversion under all circumstances should not be allowed |
Implicit conversion means GPU resident array data is going to be copied to host without explicit user control. This introduces source of hard to pin-point performance bottlenecks. CuPy does not do it for a good reason. Computation on GPU using data-parallel algorithms is generally quite a lot faster. So CuPy promotes coercion of I hope this change does not get merged, it is a regression |
The functionality introduced in #1964 can be better optimized by moving code from
_copy_utils
to theusm_ndarray
itself. This will make seamless integration into other larger codebases like scikit-learn, where use ofasarray
is common. It attempts to solve #2129