-
Notifications
You must be signed in to change notification settings - Fork 31
Technical debt clean-up in test suite #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2144/index.html |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_143 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_144 ran successfully. |
@@ -221,15 +221,6 @@ jobs: | |||
. $CONDA/etc/profile.d/conda.sh | |||
conda activate ${{ env.TEST_ENV_NAME }} | |||
python -c "import dpctl; dpctl.lsplatform(verbosity=2)" | |||
- name: Install gdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful in the future, when we will need to debug some test.
Would it be better to comment instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured we'd just write it back in later if it becomes necessary again, we could just comment though
8f68787
to
86965dd
Compare
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_160 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_164 ran successfully. |
also fixes a typo
no longer needed since crash was resolved
also consolidates two add tests
this test keeps test coverage of some branches related to type resolution
d2d4e5a
to
d97f840
Compare
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_191 ran successfully. |
This PR proposes reducing the scope of the dpctl test suite by redacting tests which are redundant
For example, the dpctl test suite for element-wise functions repeatedly tests for things like
usm_type
of the output array. But the output arrayusm_type
is determined in the function which dispatches to the element-wise kernel, and therefore, only needs to be tested once