Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

This PR proposes reducing the scope of the dpctl test suite by redacting tests which are redundant

For example, the dpctl test suite for element-wise functions repeatedly tests for things like usm_type of the output array. But the output array usm_type is determined in the function which dispatches to the element-wise kernel, and therefore, only needs to be tested once

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2025

Coverage Status

coverage: 85.24% (-0.02%) from 85.262%
when pulling d97f840 on reduce-bloat-in-dpctl-test-suite
into 878cc19 on master.

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_143 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_144 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@@ -221,15 +221,6 @@ jobs:
. $CONDA/etc/profile.d/conda.sh
conda activate ${{ env.TEST_ENV_NAME }}
python -c "import dpctl; dpctl.lsplatform(verbosity=2)"
- name: Install gdb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful in the future, when we will need to debug some test.
Would it be better to comment instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we'd just write it back in later if it becomes necessary again, we could just comment though

@ndgrigorian ndgrigorian force-pushed the reduce-bloat-in-dpctl-test-suite branch from 8f68787 to 86965dd Compare September 16, 2025 21:41
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_160 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_164 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the reduce-bloat-in-dpctl-test-suite branch from d2d4e5a to d97f840 Compare September 17, 2025 23:17
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_191 ran successfully.
Passed: 1113
Failed: 8
Skipped: 119

@ndgrigorian ndgrigorian marked this pull request as ready for review September 18, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants