Update dpnp.isclose with scalar-specific SYCL kernels
#2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
AlexanderKalistratov,
vtavana and
ndgrigorian
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2540/index.html |
|
Array API standard conformance tests for dpnp=0.19.0dev2=py313h509198e_36 ran successfully. |
antonwolfy
reviewed
Jul 29, 2025
dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp
Outdated
Show resolved
Hide resolved
dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp
Outdated
Show resolved
Hide resolved
dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp
Outdated
Show resolved
Hide resolved
dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp
Outdated
Show resolved
Hide resolved
antonwolfy
reviewed
Jul 30, 2025
dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp
Outdated
Show resolved
Hide resolved
antonwolfy
reviewed
Jul 30, 2025
antonwolfy
reviewed
Jul 30, 2025
antonwolfy
reviewed
Jul 30, 2025
| if (nd == 1 && simplified_a_strides[0] == 1 && | ||
| simplified_b_strides[0] == 1 && simplified_res_strides[0] == 1) | ||
| { | ||
| // Special case of contiguous data |
There was a problem hiding this comment.
seems no test is covering that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests updating
dpnp.isclose()function adding a scalar-specific SYCL kernels for both contiguous and stride cases to improve performance whenrtolandatolare scalars.Also extends and updates tests for
dpnp.isclose()The new kernel improves performance by up to 10x compared to the previous implementation when
rtolandatolare scalars (tested on PVC).CPU results:
GPU results:
