Capturing previously dismissed records on status:2 response#581
Open
magoo wants to merge 2 commits intoIntelligenceX:masterfrom
Open
Capturing previously dismissed records on status:2 response#581magoo wants to merge 2 commits intoIntelligenceX:masterfrom
magoo wants to merge 2 commits intoIntelligenceX:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the export_accounts() function receives a
status:2response to indicate that the results are complete. However, it doesn't capture any records that are sent along with that final response. This is a pretty simple fix that captures any remaining records that came with the final response, and then subtracts frommaxresultsas it would previously so the search can be terminated.