Skip to content

CPW-207-Assignment-2-Logan#24

Draft
logprogrammer92 wants to merge 6 commits intomainfrom
CPW-207-Assignment-2
Draft

CPW-207-Assignment-2-Logan#24
logprogrammer92 wants to merge 6 commits intomainfrom
CPW-207-Assignment-2

Conversation

@logprogrammer92
Copy link
Contributor

@logprogrammer92 logprogrammer92 commented Jan 27, 2026

Add CRC cards documentation for Game, User, Friend and Conversations entities.

@SuperGamer001 SuperGamer001 added the assignment Issue/PR is for a school assignment label Jan 29, 2026
@logprogrammer92 logprogrammer92 marked this pull request as draft February 17, 2026 02:24
Copy link

@rachelkingCPTC rachelkingCPTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperGamer001 hoping to resolve the discrepancies between your two PRs. Who was supposed to work on which class? Which is the correct version you are submitting?

Comment on lines +25 to +32
## Friends

**Responsibilities**
- Links users together
- Holds a friendship ID

**Collaborators**
- Users

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think some collaboration could have taken place between you and @SuperGamer001 . Looks like you both have a Friend or Friends class that are similar but not identical.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we supposed to be working on this together as a team and only turning in one pull request for the entire project? Or are we each supposed to turn in individual versions?

Copy link
Member

@SuperGamer001 SuperGamer001 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we do different versions, do we also cover different classes?


**Collaborators**
- Users
- Friends No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with Conversations

Copy link

@rachelkingCPTC rachelkingCPTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logprogrammer92 @SuperGamer001 I am still seeing differences between your CRC Cards for the same entities. Friend and Conversation have different collaborators as compared to Alex's PR.

Glad to see you guys divvy up classes and do your own analysis, but I do want to have a shared understanding when there is overlap. For example, does Friend collaborate with Notification and Conversation, or doesn't it?

@SuperGamer001
Copy link
Member

@rachelkingCPTC It does for both those classes. Logan doesn't cover Notifications in his CRC Card though.

Is mentioning a class that doesn't exist in the CRC Card (but still is in the actual program) allowed?

@rachelkingCPTC
Copy link

@SuperGamer001 yes, you should agree upon what classes exist and then each take a few cards for which to make CRC Cards. So you won't have all the classes existing in each PR.

@logprogrammer92
Copy link
Contributor Author

@rachelkingCPTC Ok we agreed and updated the CRC-Cards to reflect this mutual agreement.

@SuperGamer001
Copy link
Member

SuperSmashBrosMarioGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assignment Issue/PR is for a school assignment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants