Skip to content

Inspectcode scrolls, has the correct window title #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2025

Conversation

rmkaplan
Copy link
Contributor

INSPECTCODE now calls TEDIT - READONLY so that it has a process, instead of OPENTEXTSTREAM (which was also specified as readonly but without a process no sure what that does--TBD).

Also eliminated the override of the given title by the default. That may also fix the lafite title problem.

@MattHeffron
Copy link
Contributor

How much, if any, of my lispusers/INSPECTCODE-TEDIT package (from 1985-1987) could/should be merged into \TEDIT.INSPECTCODE?

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Jul 22, 2025 via email

@rmkaplan
Copy link
Contributor Author

@nbriggs , can you check to see if this fixes the Lafite title problem in #2210 ? I get an NS error when I try to start up Lafite.

@nbriggs
Copy link
Contributor

nbriggs commented Jul 23, 2025

@rmkaplan -- Yes, this fixes the Lafite title problem in #2210 . Thanks.

@nbriggs
Copy link
Contributor

nbriggs commented Jul 23, 2025

Any idea why every time you left-click or middle-click in the title bar of the Inspectcode window it adds a process (which seems to exit almost immediately) -- ADD.PROCESS: Arg 1 = (TEDIT.DEFAULT.MENUFN (QUOTE {WINDOW}#157,nnnn)))

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Jul 23, 2025 via email

@rmkaplan
Copy link
Contributor Author

I changed the FILETYPE for LLDISPLAY to :FAKE-COMPILE-FILE. Note that the LCOM file say that it was COMPILE-FILEd even though it was actual FAKE-COMPILE-FILEd.

Also, (FINDCALLERS :FAKE-COMPILE-FILE --) and (FINDCALLERS 'FAKE-COMPILE-FILE --) give the same hits. Is that a good thing?

@nbriggs
Copy link
Contributor

nbriggs commented Jul 28, 2025

Yes, I'd noticed that it still said "COMPILE-FILEd" - probably fine, since it's faking COMPILE-FILE...

I bet FINDCALLERS is using the equivalent of the PRIN1 name of the atom which ignores the package. It's handy if you don't know what package the thing you're looking for is actually in (after any imports (and so on) are resolved)

Copy link
Contributor

@MattHeffron MattHeffron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to work with PR #2224

@rmkaplan rmkaplan merged commit bc7269e into master Jul 30, 2025
@rmkaplan rmkaplan deleted the rmk106--Fix--inspectcode-and-window-title branch July 30, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants