Skip to content

Conversation

@polarismail
Copy link
Contributor

Load small files to memory to stabilize the upload from networked drives.

Bug detailed here but no fix from Google yet...

https://issues.chromium.org/issues/40123366

I pasted from our source, I see it diffed the entire file even whitespaces despite the fact that we only added a few lines.

Load small files to memory to stabilize the upload from networked drives. 

Bug detailed here but no fix from Google yet...

https://issues.chromium.org/issues/40123366
@mschering
Copy link
Member

In the diff it's hard to see what's changed as the whole file seems replaced. Can you tell me what changed?

@polarismail
Copy link
Contributor Author

I don't know why GitHub shows it like this by default. If I force to show the commit without whitespaces diff then it shows fine, please see here:

ba0f6d3?w=1

Basically we are loading files <10MB to memory directly - if you try to upload to GO from Google Drive on Android with current code it will fail. This commit fixes this problem.

@mschering
Copy link
Member

Thanks, why do you always do it for small files? It seems to cause unnecessary overhead. This only happens on chrome on android doesn't it?

@polarismail
Copy link
Contributor Author

For small files the footprint in memory at 10Mb is negligeable with today's devices and it might prevent issues on other platforms where network drives haave't been properly tested. You can remove that if clause if you want but I don't think there's any harm in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants