-
Notifications
You must be signed in to change notification settings - Fork 60
Feat: kg evaluator #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: kg evaluator #135
Conversation
Summary of ChangesHello @CHERRY-ui8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust and multi-faceted knowledge graph (KG) evaluation system. It aims to provide developers with tools to automatically assess the quality of generated KGs by examining their accuracy in extracting information, consistency in data representation, and the overall structural integrity. This feature enhances the reliability and trustworthiness of KGs produced by the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive Knowledge Graph (KG) Quality Evaluation module, encompassing accuracy, consistency, and structural robustness assessments. New files accuracy_evaluator.py, consistency_evaluator.py, and structure_evaluator.py implement these evaluations, with KGQualityEvaluator.py orchestrating them and utils.py providing helper functions like convert_to_networkx and text retrieval. An entry point evaluate_kg.py is added with command-line arguments for configuration and output, along with a shell script example and a detailed README.md. Review comments highlight several areas for improvement: the summary printing logic in evaluate_kg.py should use the pass flags from the StructureEvaluator results instead of re-implementing thresholds; the evaluation of relations and triples in accuracy_evaluator.py is redundant and should be consolidated; the metric calculation logic (precision, recall, F1) in accuracy_evaluator.py is duplicated and needs extraction into a helper method; structural metric thresholds and magic numbers for text truncation and conflict limits should be defined as class-level constants; the approximation of recall as precision in accuracy_evaluator.py is noted as potentially misleading; the get_relevant_text utility function's fallback behavior is questioned for potential memory issues; and minor code hygiene issues like unused imports and import placement are identified.
…to feat/kg-evaluator
…to feat/kg-evaluator
This pull request introduces a robust and multi-faceted knowledge graph (KG) evaluation system. It aims to provide developers with tools to automatically assess the quality of generated KGs by examining their accuracy in extracting information, consistency in data representation, and the overall structural integrity. This feature enhances the reliability and trustworthiness of KGs produced by the system.