Fix: TC in CIccSingleSampledCurveXml() #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsscx
added
PR
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix undefined behavior (UB) reported in issue #390 related to unsafe downcasting in CIccSingleSampledeCurveXml(). The changes primarily improve code style by replacing C-style casts with static_cast, removing unnecessary parentheses, and adding braces to else clauses for consistency. However, the PR does not actually resolve the underlying undefined behavior issue.
Key changes:
- Replaced C-style casts with
static_castfor three curve type conversions - Removed unnecessary parentheses around conditional expressions
- Added braces to the final else clause for consistency with K&R style
Member
Author
Maintainer NoteWed Dec 31 05:08:17 PM UTC 2025 Copilot review has been adjusted. |
ChrisCoxArt
approved these changes
Dec 31, 2025
Member
Author
SummaryThu Jan 1 03:04:11 AM UTC 2026 This PR does not solve the issues.
The Issue appears to require a deeper refactor across multiple files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
Pull Request Checklist