Skip to content

Fix: UB runtime error: member call at IccProfLib/IccMpeBasic.cpp#L4051 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 1 commit into from
Jan 1, 2026
Merged

Fix: UB runtime error: member call at IccProfLib/IccMpeBasic.cpp#L4051 #401

xsscx merged 1 commit into from
Jan 1, 2026

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Jan 1, 2026

Fixes #394

Either fix alone solves the null dereference, but both make the code a lot safer.

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt
Check for missing tonemap functions when reading, and for null functi…
e72361d 
…ons when writing

Either fix alone solves the null dereference, but both make the code a lot safer.
Fixes #394
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 1, 2026 20:27
@xsscx xsscx self-assigned this Jan 1, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers Security Security Related Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 1, 2026
xsscx
xsscx approved these changes Jan 1, 2026
View reviewed changes
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thu Jan 1 09:55:45 PM UTC 2026

@xsscx xsscx removed the Review in Process PR being Reviewed by Maintainers label Jan 1, 2026
@xsscx xsscx changed the title Check for missing tonemap functions when reading XML and writing Fix: UB runtime error: member call at IccProfLib/IccMpeBasic.cpp#L4051 Jan 1, 2026
@xsscx xsscx merged commit b200a62 into master Jan 1, 2026
25 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

Merged Merged PR Pull Request Security Security Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UB runtime error: member call at IccProfLib/IccMpeBasic.cpp#L4051

3 participants

@ChrisCoxArt @xsscx