Skip to content

Add: initialize language and country codes in LocalizedUnicode class #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 2 commits into from
Jan 5, 2026
Merged

Add: initialize language and country codes in LocalizedUnicode class #443

xsscx merged 2 commits into from
Jan 5, 2026

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Jan 5, 2026

Fixes #439

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 5, 2026 02:58
@xsscx xsscx self-assigned this Jan 5, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx
Copy link
Member

xsscx commented Jan 5, 2026

Mon Jan 5 03:00:54 AM UTC 2026

@xsscx xsscx changed the title initialize language and country codes in LocalizedUnicode class Add: initialize language and country codes in LocalizedUnicode class Jan 5, 2026
@xsscx
Copy link
Member

xsscx commented Jan 5, 2026

Status

Mon Jan 5 03:04:23 AM UTC 2026

Just waiting on CI to complete https://github.com/InternationalColorConsortium/iccDEV/actions/runs/20703709242/job/59430274023 then will Merge.

Thank You

@ChrisCoxArt
Copy link
Contributor Author

ChrisCoxArt commented Jan 5, 2026

I checked in my fix for #440 as well, by mistake.
I might be doing a little too fast tonight.

@xsscx xsscx merged commit 45e81db into master Jan 5, 2026
17 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 5, 2026
@ChrisCoxArt ChrisCoxArt mentioned this pull request Jan 5, 2026
Closed
@xsscx xsscx linked an issue Jan 6, 2026 that may be closed by this pull request
SAST Report on function ‘icFloatNumber icF16toF(icFloat16Number)’: ‘rv’ is used uninitialized #440
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

Merged Merged PR Pull Request

Projects

None yet

Milestone

No milestone

3 participants

@ChrisCoxArt @xsscx