Skip to content

Modify: icMemDump change strncpy to memcpy, add comments #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsscx merged 1 commit into from
Jan 5, 2026
Merged

Modify: icMemDump change strncpy to memcpy, add comments #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions IccProfLib/IccUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,11 +980,11 @@ void icMemDump(std::string &sDump, void *pBuf, size_t nNum)
buf[77] = '\n';
buf[78] = '\0';
snprintf(num, numSize, "%08X:", uint32_t(i)); // NOTE - this formatting will have to change if we want to move beyond 4 Gig.
strncpy(buf, num, 9);
memcpy(buf, num, 9); // 8 hex digits, plus ':', and no terminating NULL
}

snprintf(num, numSize, "%02X", *pData);
strncpy(buf+10+j*3, num, 2);
memcpy(buf+10+j*3, num, 2); // 2 hex digits, no terminating NULL

c=*pData;
if (!isprint(c) || c > 126)
Expand Down
Loading