Skip to content

Modify: Banner, misc. fixes to iccV5DspObsToV4Dsp #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 1 commit into from
Jan 5, 2026
Merged

Modify: Banner, misc. fixes to iccV5DspObsToV4Dsp #446

xsscx merged 1 commit into from
Jan 5, 2026

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Jan 5, 2026

Add more descriptive program usage
cleanup pointer usage
add comments
Not a complete fix for #187
But it should help.

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt
improved usage, misc. fixes
a2e98b7 
Add more descriptive program usage
cleanup pointer usage
add comments
part of #187
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 5, 2026 03:34
@xsscx xsscx self-assigned this Jan 5, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx xsscx changed the title improved usage, misc. fixes to iccV5DspObsToV4Dsp Modify: Banner, misc. fixes to iccV5DspObsToV4Dsp Jan 5, 2026
xsscx
xsscx approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mon Jan 5 03:49:42 AM UTC 2026

@xsscx
Copy link
Member

xsscx commented Jan 5, 2026

Summary

Tools/IccV5DspObsToV4Dsp/iccV5DspObsToV4Dsp

Usage: iccV5DspObsToV4Dsp inputV5.icc inputObserverV5.icc outputV4.icc
Convert an ICCVersion5 display and observer to ICCVersion4 display profile,
allowing version5 profiles to be used by legacy applications.
inputV5.icc: input version5 display profile
inputObserverV5.icc: input version5 observer profile
outputV4.icc: output version4 display profile
Built with IccProfLib version 2.3.1.2

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx xsscx merged commit da385b2 into master Jan 5, 2026
23 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 5, 2026
@xsscx xsscx linked an issue Jan 5, 2026 that may be closed by this pull request
Add Documentation for iccV5DspObsToV4Dsp to Project Documentation #187
Closed
This was referenced Jan 6, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

Merged Merged PR Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Documentation for iccV5DspObsToV4Dsp to Project Documentation

3 participants

@ChrisCoxArt @xsscx