Fix: HBO in CIccProfileXml::ParseBasic() at IccXML/IccLibXML/IccProfileXml.cpp #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsscx
approved these changes
Jan 6, 2026
Member
xsscx
left a comment
xsscx
left a comment
There was a problem hiding this comment.
Repro
Tue Jan 6 16:36:33 EST 2026
8156d5e
8156d5e (HEAD -> pr-451, origin/issue-448) fix typo so we check for a NULL character instead of a NULL pointer
Testing % ../Build/Tools/IccFromXml/iccFromXml CVE-2024-38427-public-domain-example-proof-of-concept-poc-buffer-overflow.xml oops.icc
Expected Output
Profile parsed. Profile is invalid, but saved correctly
Warning! - Unknown 'HOYT' = 484F5954: Unknown platform signature.
Warning! - Major version number (66) is unexpected.
Warning! - Unknown 'hoyt' = 686F7974: Unregistered CMM signature.
NonCompliant! - profileDescriptionTag textDescriptionType: Invalid tag type (Might be critical!).
NonCompliant! - copyrightTag textType: Invalid tag type (Might be critical!).
NonCompliant! - deviceModelDescTag textDescriptionType: Invalid tag type (Might be critical!).
NonCompliant! - deviceMfgDescTag textDescriptionType: Invalid tag type (Might be critical!).
xsscx
added
Merged
xsscx
changed the title
xsscx
added
Merged
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448
Pull Request Checklist