Skip to content

Conversation

@xsscx
Copy link
Member

@xsscx xsscx commented Jan 7, 2026

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@xsscx xsscx requested a review from ChrisCoxArt January 7, 2026 01:47
@xsscx xsscx self-assigned this Jan 7, 2026
Copilot AI review requested due to automatic review settings January 7, 2026 01:47
@xsscx xsscx added PR Pull Request Testing Modifying Testing Directory Configuration Configuration Issues Merge Ready Maintainer indicates Merge Ready CI labels Jan 7, 2026
@xsscx xsscx linked an issue Jan 7, 2026 that may be closed by this pull request
@xsscx
Copy link
Member Author

xsscx commented Jan 7, 2026

PR Summary

Fixes a bad path and now we have:

*****************************************************************
Apply PCC's to the spectral images to get colorimetric renderings
*****************************************************************

C:\tmp\iccDEV\Testing\hybrid>iccApplyProfiles.exe Data\smCows380_5_780.tif Results\cowsA_fromRef.tif 1 1 0 1 1 -embedded 3 -pcc ICC\Spec400_10_700-illumA_2deg-Abs.icc ..\sRGB_v4_ICC_preference.icc 1
TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%

C:\tmp\iccDEV\Testing\hybrid>iccApplyProfiles.exe Results\MS_smCows.tif Results\cowsA_fromMS.tif 1 1 0 1 1 -embedded 10003 -pcc ICC\Spec400_10_700-illumA_2deg-Abs.icc ..\sRGB_v4_ICC_preference.icc 1
100%

C:\tmp\iccDEV\Testing\hybrid>iccApplyProfiles.exe Data\smCows380_5_780.tif Results\cowsF11_fromRef.tif 1 1 0 1 1 -embedded 3 -pcc ICC\Spec400_10_700-F11_2deg-Abs.icc ..\sRGB_v4_ICC_preference.icc 1
TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%

C:\tmp\iccDEV\Testing\hybrid>iccApplyProfiles.exe Results\MS_smCows.tif Results\cowsF11_fromMS.tif 1 1 0 1 1 -embedded 10003 -pcc ICC\Spec400_10_700-F11_2deg-Abs.icc ..\sRGB_v4_ICC_preference.icc 1
100%

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects an incorrect file path reference in the Windows batch testing script. The sRGB_v4_ICC_preference.icc ICC profile file was incorrectly being prefixed with %TOOLDIR%, which is a variable meant for executable paths, not data files.

  • Corrects the path to sRGB_v4_ICC_preference.icc from %TOOLDIR%sRGB_v4_ICC_preference.icc to ..\sRGB_v4_ICC_preference.icc
  • Brings the Windows batch script into alignment with the existing shell script version
  • Ensures the script can correctly locate the ICC profile file in the parent Testing directory

@xsscx xsscx merged commit cfcd06c into master Jan 7, 2026
28 checks passed
@xsscx xsscx added Merged Merged and removed Merge Ready Maintainer indicates Merge Ready labels Jan 7, 2026
@xsscx xsscx deleted the fix-hybrid-tests branch January 7, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Configuration Configuration Issues Merged Merged PR Pull Request Testing Modifying Testing Directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO: Fix BuildAndTest.bat in Testing/hybrid

3 participants