Skip to content

Fix: Path in Testing/mcs/ scripts #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 1 commit into from
Jan 7, 2026
Merged

Fix: Path in Testing/mcs/ scripts #460

xsscx merged 1 commit into from
Jan 7, 2026

Conversation

@xsscx
Copy link
Member

@xsscx xsscx commented Jan 7, 2026

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@xsscx xsscx requested a review from ChrisCoxArt January 7, 2026 02:49
@xsscx xsscx self-assigned this Jan 7, 2026
@xsscx xsscx added PR Pull Request Testing Modifying Testing Directory ci-no-source ci-no-source indicates no source code changes bypassing ci-build-matrix label Configuration Configuration Issues Merge Ready Maintainer indicates Merge Ready labels Jan 7, 2026
Copilot AI review requested due to automatic review settings January 7, 2026 02:49
@xsscx xsscx added the CI label Jan 7, 2026
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the ICC profile path reference in the Testing/mcs/updateprev.bat script, changing from the outdated sRGB_IEC61966_21.icm to the standard sRGB_v4_ICC_preference.icc file that exists in the Testing directory and is used throughout the rest of the codebase.

Key changes:

  • Updated ICC profile reference from ..\sRGB_IEC61966_21.icm to ..\sRGB_v4_ICC_preference.icc in the batch script command

@xsscx xsscx linked an issue Jan 7, 2026 that may be closed by this pull request
Fix: Path in Testing/mcs/updateprev.bat #461
Closed
@xsscx xsscx changed the title Fix: Path in Testing/mcs/updateprev.bat Fix: Path in Testing/mcs/ scripts Jan 7, 2026
@xsscx
Fix: Path in Testing/mcs/ scripts
f793db9 
Fix: Path in Testing/mcs/ scripts
@xsscx xsscx requested a review from Copilot January 7, 2026 03:30
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@xsscx xsscx merged commit a01e4a8 into master Jan 7, 2026
18 checks passed
@xsscx xsscx added Merged Merged and removed Merge Ready Maintainer indicates Merge Ready labels Jan 7, 2026
@xsscx xsscx deleted the fix-mcs-scripts branch January 7, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ChrisCoxArt ChrisCoxArt ChrisCoxArt approved these changes

Assignees

@xsscx xsscx

Labels

CI ci-no-source ci-no-source indicates no source code changes bypassing ci-build-matrix label Configuration Configuration Issues Merged Merged PR Pull Request Testing Modifying Testing Directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix: Path in Testing/mcs/updateprev.bat

3 participants

@xsscx @ChrisCoxArt