Skip to content

Conversation

@ChrisCoxArt
Copy link
Contributor

Max added a build change and another macro test change.

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

ChrisCoxArt and others added 3 commits January 5, 2026 17:49
Create function to find and return first of either macro syntax.
Add tweaks to CIccMpeXmlCalculator::ValidMacroCalls to deal with both syntax forms.
remove my previous self reference detection, now that we have more robust recursion detection for macros.
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 7, 2026 08:33
@xsscx xsscx self-assigned this Jan 7, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers labels Jan 7, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wed Jan 7 10:47:00 AM UTC 2026

@xsscx xsscx merged commit dbb150d into master Jan 7, 2026
21 checks passed
@xsscx xsscx added Merged Merged and removed Review in Process PR being Reviewed by Maintainers labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants