Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a cutoff date after which new deposits are blocked and bumps the CLI version.
- Introduces
DEPOSIT_CLOSE_TIMESTAMPconstant and checks current time against it - Emits a warning when a deposit would occur after the cutoff
- Updates
Cargo.tomlversion to 1.3.1
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/services/mod.rs | Implement deposit-close logic and warning output |
| Cargo.toml | Bump version from 1.3.0 to 1.3.1 |
Comments suppressed due to low confidence (3)
src/services/mod.rs:19
- Add a doc comment for
DEPOSIT_CLOSE_TIMESTAMPto explain its role, e.g.,/// Timestamp after which deposits are closed (2025-06-28 00:00:00 UTC).
const DEPOSIT_CLOSE_TIMESTAMP: u64 = 1751068800; // 2025-06-28 00:00:00 UTC
src/services/mod.rs:54
- There are no tests covering the new deposit-close behavior. Please add unit or integration tests that simulate timestamps before and after
DEPOSIT_CLOSE_TIMESTAMPto verify both blocking and warning logic.
let is_open = (chrono::Utc::now().timestamp() as u64) < DEPOSIT_CLOSE_TIMESTAMP;
src/services/mod.rs:62
- The warning string uses a multi-line literal with leading spaces, which will introduce unwanted indentation in the output. Consider using an explicit
\nor a raw string literal without indentation to produce a clean message.
You can still withdraw your deposits but cannot make new deposits.",
smallbabybear
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.