Skip to content

feat: view key option#478

Open
kbizikav wants to merge 1 commit intodevfrom
cherry-pick-view-key
Open

feat: view key option#478
kbizikav wants to merge 1 commit intodevfrom
cherry-pick-view-key

Conversation

@kbizikav
Copy link
Collaborator

Summary

  • Add view key option to CLI commands
  • Cherry-picked from main-view-key branch

Test plan

  • Verify CLI commands work with view key option
  • Test existing functionality remains unchanged

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings January 21, 2026 16:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a --view-key option to CLI commands as an alternative to --private-key for read-only operations. Users can now provide either a view key or a private key for commands that don't require spend authority.

Changes:

  • Added resolve_view_pair function to handle view key or private key input
  • Updated 14 CLI commands to accept optional --view-key parameter with mutual exclusivity constraints
  • Modified command handlers to use the new resolution logic

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
cli/src/args.rs Added optional view_key parameter to 14 commands with required_unless_present constraints for mutual exclusivity with private_key
cli/src/format.rs Implemented viewkey_to_viewpair and resolve_view_pair functions to convert view keys to ViewPair and handle input resolution
cli/src/main.rs Updated command handlers to use resolve_view_pair instead of direct privkey_to_keypair calls, and added import for the new function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant