Deprecate "old" certificate api helper functions #983
+692
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
8a5595f to
6519563
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
6519563 to
81b7a98
Compare
Jimbo4350
changed the title
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
2 times, most recently
from
71a4ef9 to
b968b7b
Compare
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond,
newhoggy and
palas
as code owners
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
2 times, most recently
from
d261519 to
a73bd18
Compare
- Cardano.Api.Experimental.Tx.Internal.Certificate.Compatible - Cardano.Api.Experimental.Certificate Introduce Delegatee type family to capture the era dependent nature of delegatees (stake pool delegation vs vote delegation etc)
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
a73bd18 to
2d0f85b
Compare
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
afaa27a to
44a52ba
Compare
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
44a52ba to
44a720e
Compare
carbolymer
reviewed
Oct 28, 2025
| , L.EraTxOut (LedgerEra era) | ||
| , L.EraUTxO (LedgerEra era) | ||
| , FromCBOR (ChainDepState (ConsensusProtocol era)) | ||
| , FromCBOR (L.TxCert (LedgerEra era)) |
There was a problem hiding this comment.
Is this required? EraTxCert era already provides FromCBOR (TxCert era)
carbolymer
reviewed
Oct 28, 2025
Comment on lines
+34
to
+37
| ( Typeable ledgerera | ||
| , L.Era ledgerera | ||
| , FromCBOR (L.TxCert ledgerera) | ||
| , L.EraTxCert ledgerera |
There was a problem hiding this comment.
Those four constraints feel redundant here, because:
- they're provided by
EraandEraTxCertledger constraints https://cardano-ledger.cardano.intersectmbo.org/cardano-ledger-shelley/Cardano-Ledger-Shelley-TxCert.html#t:TxCert Certificatealready providesEraTxCert- They're not really necessary for the implementation of
HasTextEnvelope
carbolymer
reviewed
Oct 28, 2025
Comment on lines
+48
to
+50
| ( Typeable ledgerera | ||
| , L.Era ledgerera | ||
| , FromCBOR (L.TxCert ledgerera) |
There was a problem hiding this comment.
Same thing, those three constraints feel redundant here, because they're provided by EraTxCert ledger constraints https://cardano-ledger.cardano.intersectmbo.org/cardano-ledger-shelley/Cardano-Ledger-Shelley-TxCert.html#t:TxCert
carbolymer
approved these changes
Oct 28, 2025
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
945ec57 to
f6ab5fd
Compare
Jimbo4350
force-pushed
the
jordan/backwarks-compatible-certificates
branch
from
f6ab5fd to
61e76fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist