-
Couldn't load subscription status.
- Fork 33
Return the last read key when doing range reads #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I plan on merging this as a PR stack:
This is a graph of the dependencies of the PRs |
efdf425 to
2421e01
Compare
80421ad to
7f77886
Compare
7f77886 to
8aa430b
Compare
8aa430b to
9fca513
Compare
9fca513 to
bafbd1c
Compare
bafbd1c to
6748c08
Compare
6748c08 to
bcc5b88
Compare
bcc5b88 to
26f08d1
Compare
26f08d1 to
3269dc7
Compare
55e952e to
a3dc493
Compare
3269dc7 to
66c3d48
Compare
LSM trees use an ordering different than the Haskell `Ord`. This commit enriches the type returned by range reads so that the maximal key is returned, which is then given back to the next iteration of the range reading loop.
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Forker.hs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only minor taste-related concern is returning a tuple that's a bit contextless instead of some kind of data type with two fields, but otherwise happy with this
No description provided.