Peer selection bugfix and testing updates #5209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
from
ed681ae to
f9f39da
Compare
coot
reviewed
Oct 6, 2025
ouroboros-network/testlib/Test/Ouroboros/Network/Diffusion/Testnet/Cardano.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/changelog.d/20251004_134906_crocodile-dentist_test_false_positive.md
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
6 times, most recently
from
7636304 to
3ad6525
Compare
crocodile-dentist
added
bug
crocodile-dentist
changed the title
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
4 times, most recently
from
4795244 to
054e3f4
Compare
coot
reviewed
Oct 17, 2025
ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/ActivePeers.hs
Show resolved
Hide resolved
ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/EstablishedPeers.hs
Show resolved
Hide resolved
ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/EstablishedPeers.hs
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/PeerSelection.hs
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
from
054e3f4 to
d9b184b
Compare
Changes address the issue of peer selection not taking the opportunity to demote peers, or demoting too many under specific conditions.
The patch addresses an issue where a promotion opportunity may be missed.
The patch addresses an issue where a promotion opportunity may be missed.
Don't promote local root peers here, there is `belowTargetLocal` for that which properly accounts for valencies from topology file.
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
2 times, most recently
from
2115015 to
fe9de22
Compare
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
from
fe9de22 to
1024d68
Compare
coot
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Just some minor comments. Thanks @crocodile-dentist, it's a thorough review of some of the peer selection intricate logic.
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/Monitor.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/tests-lib/lib/Test/Ouroboros/Network/Data/Signal.hs
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mw/test-false-positive
branch
from
1024d68 to
0ddc581
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testnet bugfix: prop_diffusion_target_active_below: A missed promotion opportunity is signalled causing
IOSim.target active belowtest to fail while the peer is being synchronously demoted from warm state and hence is not a viable opportunity.Reworked approach to peer selection tests.
resolves #5206
Checklist
Quality
Maintenance
ouroboros-networkproject.