Skip to content

Conversation

@menvae
Copy link
Contributor

@menvae menvae commented Oct 5, 2025

Clicking on scroll velocity and multiplier tags doesn't open the point in question.
This makes it so that points can be referenced from other pointslists.

Changes:

  • Add new EditorTagDependencies for opening points from any points list
  • Make Tags offsetted on hover
    • This is to imply that tags are clickable
  • Made CurrentTab in Editor public (only get) and a bindable

Old Description

Clicking on scroll velocity and multiplier tags opens the sidebar in charting tab not their actual housing sidebar.

One caveat and I don't have a fix for it, is that design tab has to be loaded otherwise when switching to design tab and trying to show the entry nothing happens because it hasn't loaded yet. Other than that if design is already loaded (eg. just enter it one time) it will work fine.

Changes:

  • Add new EditorTagDependencies for opening points in any points list
  • Make Tags offsetted on hover
    • This is to imply that tags are clickable
  • Made CurrentTab in Editor public (only get) and a bindable

@menvae
Copy link
Contributor Author

menvae commented Oct 5, 2025

Also I should mention that EditorTagDependencies switches tabs based on fixed values.
I don't know if this is okay or will cause problems later on, like changing order of tabs.

public void ShowPointInCharting(ITimedObject obj)
    {
        ChangeTab(1);
        ChartingPoints.ShowPoint(obj);
    }

    public void ShowPointInDesign(ITimedObject obj)
    {
        ChangeTab(2);
        DesignPoints.ShowPoint(obj);
    }

@menvae menvae changed the title Allow Tags To Switch Editor Tabs Allow PointsList/PointsSidebar to open the settings of other PointsLists/Sidebars Oct 14, 2025
@menvae
Copy link
Contributor Author

menvae commented Oct 14, 2025

Also I should mention that EditorTagDependencies switches tabs based on fixed values. I don't know if this is okay or will cause problems later on, like changing order of tabs.

public void ShowPointInCharting(ITimedObject obj)
    {
        ChangeTab(1);
        ChartingPoints.ShowPoint(obj);
    }

    public void ShowPointInDesign(ITimedObject obj)
    {
        ChangeTab(2);
        DesignPoints.ShowPoint(obj);
    }

This is kinda outdated as of the latest commit. the change tab method is still here just in case,
Just in case of adding an option to also switch tabs instead of just opening them, maybe it might be helpful.

@menvae menvae marked this pull request as draft October 14, 2025 17:18
by "improving" what this actually means is just fully loading design tab so that we can safely reference its children
@menvae menvae marked this pull request as ready for review October 15, 2025 12:14
@flustix flustix added this to fluXis Nov 14, 2025
@flustix flustix moved this to in review in fluXis Nov 14, 2025
menvae and others added 2 commits December 6, 2025 15:31
+ change tabs using variants instead of int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: in review

Development

Successfully merging this pull request may close these issues.

2 participants