-
Notifications
You must be signed in to change notification settings - Fork 23
Allow PointsList/PointsSidebar to open the settings of other PointsLists/Sidebars #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Also I should mention that public void ShowPointInCharting(ITimedObject obj)
{
ChangeTab(1);
ChartingPoints.ShowPoint(obj);
}
public void ShowPointInDesign(ITimedObject obj)
{
ChangeTab(2);
DesignPoints.ShowPoint(obj);
} |
This is kinda outdated as of the latest commit. the change tab method is still here just in case, |
by "improving" what this actually means is just fully loading design tab so that we can safely reference its children
+ change tabs using variants instead of int
Clicking on scroll velocity and multiplier tags doesn't open the point in question.
This makes it so that points can be referenced from other pointslists.
Changes:
EditorTagDependenciesfor opening points from any points listCurrentTabinEditorpublic (only get) and a bindableOld Description
Clicking on scroll velocity and multiplier tags opens the sidebar in charting tab not their actual housing sidebar.
One caveat and I don't have a fix for it, is that design tab has to be loaded otherwise when switching to design tab and trying to show the entry nothing happens because it hasn't loaded yet. Other than that if design is already loaded (eg. just enter it one time) it will work fine.
Changes:
EditorTagDependenciesfor opening points in any points listCurrentTabinEditorpublic (only get) and a bindable