consider various edge cases when converting osu mania maps #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr does the following
i tried to explain things as clearly as possible in comments to make sure anyone who doesn't know about these edge cases can understand why i did things this way, but this might feel over-commented idk
i obviously haven't tested every sv map in existence, but here are some of the most cursed maps i know converted using these changes
Hito Mania (doesn't start on the current version of the game because of p notes and cursed bpm)
hito.mp4
Digibuprofen (doesn't start on the current version of the game due to insanely high bpm) (yes this is what 1:52 IGT is supposed to look like)
digi.mp4
dont say "i can sample that" for 24 hours challenge (on the current version of the game, the bpm-only effects at 1:02 IGT don't do anything)
icansamplethat.mp4
stresstest (on the current version of the game most of the teleport effects don't work, some parts are really hard to play due to low scroll speed)
stress.mp4
closes #72 (hopefully)