Open
Conversation
fixed typo's and bugs in the notification schema fixed bugs in notifications service that returned incorrect data format
…er and user service from passing any test aside from some outaded refrences like #register in the controller test file which does not exist on the actual controller file, 'photo' was also removed from user schema. It has been readded since it caused a test to fail. this took way longer than expected and came as a shock becuase the tests worked just fine the issue was caused because of the use of 'Inject' rather than the mongoose 'InjectModel' which returns a sting and not the mongoose model itself. which made the dependency undetectable in the test files espicially when 'getModelToken' is used.
added unit tests for event endpoints and ensured presense of proper mock models
modified the events service and controller approve endpoint to accept admin id added more tests for approval event service
… tests, and injectmodel to work in test, but fail in dev since we use inject -for document- we need to pass the name which is the name in our custom shcema compiler 'dbmodule' (the name for example now being User.name) directly, rather than usin getModel() since we are not using the convetional model system
…ed issues with lead application guard not allowing users register to be leadd. the userguard was removed from this endpoint, since it first checks the request is from a lead or an admin
snebo
requested review from
Tonykaynoni,
definite-d,
oyedeletemitope and
willypelz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Notification System with Audit Trail for Lead Applications and Events
Summary