Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the main configuration function from setAttributes to Configure across the codebase.
Updated README usage examples, benchmark tests (benchmark/basiclogs_test.go, benchmark/logonce_test.go), and logger_settings.go to use the new name.
Improves clarity and aligns with common Go configuration naming.
Removed the flush function from logger.go and its usage from logger_settings.go.
Simplifies the public API by dropping an explicit flush entry point.
Added an Example Output section to the README with sample JSON log entries for INFO, DEBUG, WARN, ERROR, and TRACE.
Makes it easier for users to see the actual log format and structure before integrating.