Skip to content

update #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchelsellers merged 1 commit into from
May 16, 2025
Merged

update #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/ci-dnn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,11 @@ jobs:
- name: Build the solution
run: msbuild './ExpandableTextHtml.sln' /p:Configuration=Release;

- name: Collect Installers
if: github.event_name != 'pull_request'
run: |
md installers
Get-ChildItem -Include *install.zip -Recurse | Copy-Item -Destination "installers\"
shell: powershell
working-directory: .\

- name: Store Install Package
if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v4
with:
name: installers
path: './installers/**_install.zip'
path: './**/**_install.zip'
Copy link

@coderabbitai coderabbitai bot May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Simplify and standardize the artifact glob
The pattern ./**/**_install.zip is overly verbose and may not match installer zips at the repo root. GitHub Actions supports the simpler recursive glob **/*_install.zip, which will find all *_install.zip files at any depth, including top-level.

-        path: './**/**_install.zip'
+        path: '**/*_install.zip'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
path: './**/**_install.zip'
- path: './**/**_install.zip'
+ path: '**/*_install.zip'
🤖 Prompt for AI Agents 
In .github/workflows/ci-dnn.yml at line 34, replace the artifact path pattern
'./**/**_install.zip' with the simpler and more effective '**/*_install.zip' to
ensure it matches all installer zip files at any directory depth, including the
repository root.

retention-days: 5 # only need long enough to test/validate