Fix DNN Search Integration Implementation for DNN 10.x and Beyond#9
Fix DNN Search Integration Implementation for DNN 10.x and Beyond#9mitchelsellers merged 6 commits intomasterfrom
Conversation
Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
|
@copilot Given the nature of DNN implementation this must be added to the existing ExpandableTextHtmlController class, can you adjust that class to contain this implementation |
Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
I've moved the search implementation into the existing ExpandableTextHtmlController class as requested. The controller now inherits from ModuleSearchBase and implements the GetModifiedSearchDocuments method directly. This implementation maintains the same functionality while following the DNN implementation pattern you suggested. The changes are in commit eb2cc19. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary
This PR updates the ExpandableText module to use modern DNN search integration through the
ModuleSearchBaseapproach, replacing the older commented-outISearchableimplementation. This ensures proper search indexing in DNN 10.x and beyond.Implementation Details
ExpandableTextHtmlModuleSearchBaseclass that inherits from DNN'sModuleSearchBaseGetModifiedSearchDocumentsmethod to properly index all expandable text contentApproach
The implementation follows a minimal-change approach:
Testing
The new implementation ensures that:
Fixes #5.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.