Skip to content

Fix DNN Search Integration Implementation for DNN 10.x and Beyond#9

Merged
mitchelsellers merged 6 commits intomasterfrom
copilot/fix-5
Jul 7, 2025
Merged

Fix DNN Search Integration Implementation for DNN 10.x and Beyond#9
mitchelsellers merged 6 commits intomasterfrom
copilot/fix-5

Conversation

Copy link
Contributor

Copilot AI commented May 27, 2025

Summary

This PR updates the ExpandableText module to use modern DNN search integration through the ModuleSearchBase approach, replacing the older commented-out ISearchable implementation. This ensures proper search indexing in DNN 10.x and beyond.

Implementation Details

  • Created a new ExpandableTextHtmlModuleSearchBase class that inherits from DNN's ModuleSearchBase
  • Implemented the GetModifiedSearchDocuments method to properly index all expandable text content
  • Added proper filtering based on modified date to support incremental search indexing
  • Ensured all required metadata is included in search documents (title, content, last updated date, etc.)
  • Updated release notes to reflect the new feature (version 06.02.00)

Approach

The implementation follows a minimal-change approach:

  • No existing code was modified (the old commented-out search code was left intact for reference)
  • New functionality was added through a dedicated class that follows DNN 10.x standards
  • Proper metadata handling ensures search results will be accurate and include all relevant module content

Testing

The new implementation ensures that:

  • All expandable text items are properly indexed in DNN's search system
  • Only modified content is included in incremental indexing
  • Search results will properly link back to the module

Fixes #5.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix DNN Search Integration Implementation Fix DNN Search Integration Implementation for DNN 10.x and Beyond May 27, 2025
Copilot AI requested a review from mitchelsellers May 27, 2025 07:08
@mitchelsellers
Copy link
Contributor

@copilot Given the nature of DNN implementation this must be added to the existing ExpandableTextHtmlController class, can you adjust that class to contain this implementation

Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented May 27, 2025

@copilot Given the nature of DNN implementation this must be added to the existing ExpandableTextHtmlController class, can you adjust that class to contain this implementation

I've moved the search implementation into the existing ExpandableTextHtmlController class as requested. The controller now inherits from ModuleSearchBase and implements the GetModifiedSearchDocuments method directly. This implementation maintains the same functionality while following the DNN implementation pattern you suggested. The changes are in commit eb2cc19.

@coderabbitai
Copy link

coderabbitai bot commented Jul 7, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mitchelsellers mitchelsellers marked this pull request as ready for review July 7, 2025 05:14
@mitchelsellers mitchelsellers merged commit 6a7bd85 into master Jul 7, 2025
2 checks passed
@mitchelsellers mitchelsellers deleted the copilot/fix-5 branch July 7, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix DNN Search Integration Implementation

2 participants

Comments