Open
Conversation
ranai-srivastav
approved these changes
Apr 10, 2023
przb
reviewed
May 4, 2023
| that will move the robot in a way that will minimize the error. | ||
| """ | ||
| def minimize(error: float): | ||
| raise NotImplementedError() No newline at end of file |
Contributor
There was a problem hiding this comment.
what is our plan with these unimplemented methods?
There was a problem hiding this comment.
I assumed that there was an implementation in a different branch for this method.
| Calculates the euclidean distance between two points | ||
| """ | ||
|
|
||
| def calculate_distance(point1: Point, point2: Point): |
Contributor
There was a problem hiding this comment.
could we use an already implemented point class and distance method?
abadithela
approved these changes
May 7, 2023
|
Please only merge after the above comments have been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added general pure pursuit class