Add timeout and fix resource leaks in Git client#21
Merged
Conversation
The runGit() function had no timeout on pipe reads or process exit, which could cause hangs on large diffs. Pipe file handles were also never explicitly closed, potentially leaking file descriptors across multiple runs. Changes: - Add 60s timeout using DispatchGroup with wait(timeout:) - Add defer block to always close pipe file handles - Add gitCommandTimedOut error case for timeout failures - Use DataBox wrapper to avoid Swift concurrency warnings - Fix unrelated test checking for non-existent prompt text Fixes #17
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
runGit()function inSystemGitClienthad no timeout on pipe reads or process exit, which could cause hangs on large diffs or stalled git processes. Additionally, pipe file handles were never explicitly closed, potentially causing file descriptor exhaustion across multiple runs.Changes:
DispatchGroupwithwait(timeout:)deferblock to always close pipe file handles after readinggitCommandTimedOut(command:timeout:)error case for timeout failuresDataBoxwrapper class (@unchecked Sendable) to avoid Swift concurrency warningsTest plan
swift buildlsof)Fixes #17