Open
Conversation
anhtin
approved these changes
Feb 9, 2023
|
|
||
| fastify.post("/colleagues", (req, res) => { | ||
| const colleague = JSON.parse(req.body); | ||
| const colleague = req.body; |
Member
There was a problem hiding this comment.
Note, req.body defaults to a string if the request does not specify Content-Type: application/json. Might want to add if-statements checking the header and manually deserialize the body or return 415 Unsupported Media Type when content type is something else. Some of the previous participants were confused when seemingly correct requests didn't go through as they weren't aware that the header is neccessary.
anhtin
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some end to end tests using Playwright.
It requires that you are running the api locally on localhost:4000 and the React Intro application on localhost:3000.
This is meant to be part of the course so that the students can have a look at how it is possible to do e2e tests.
It is not optimal, but it will highlight some useful methods in testing.