[MOB-11903] consent logging refactoring #938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fixes with double values having trailing zeros
… statements for track functions
Minmatch and single item matches done with test cases
…ta2-release [MOB-10367] update pointers and changelog
# Conflicts: # CHANGELOG.md # Iterable-iOS-AppExtensions.podspec # Iterable-iOS-SDK.podspec # swift-sdk.xcodeproj/project.pbxproj # swift-sdk/Core/Constants.swift # swift-sdk/Internal/InternalIterableAPI.swift # swift-sdk/Internal/IterableUserDefaults.swift # swift-sdk/Internal/Utilities/LocalStorage.swift # swift-sdk/SDK/IterableAPI.swift # swift-sdk/SDK/IterableConfig.swift # tests/common/MockLocalStorage.swift
Co-authored-by: Evan Greer <evan.greer@evan.greer> Co-authored-by: Joao Dordio <joaodordio@icloud.com>
Co-authored-by: Megha <megha.pithadiya@iterable.com> Co-authored-by: Evan Greer <evan.greer@evan.greer>
# Conflicts: # Iterable-iOS-AppExtensions.podspec # Iterable-iOS-SDK.podspec # swift-sdk/Internal/InternalIterableAPI.swift # swift-sdk/SDK/IterableAPI.swift
Co-authored-by: Evan Greer <evan.greer@evan.greer>
# Conflicts: # Iterable-iOS-AppExtensions.podspec # Iterable-iOS-SDK.podspec # swift-sdk.xcodeproj/project.pbxproj # swift-sdk/Internal/AuthManager.swift # swift-sdk/SDK/IterableAPI.swift
…iOS SDK (#922) Co-authored-by: Joao Dordio <joaodordio@icloud.com> Co-authored-by: Evan Takeo Kanaiaupuni Greer <56953678+evantk91@users.noreply.github.com> Co-authored-by: Evan Greer <evan.greer@evan.greer>
Co-authored-by: Evan Greer <evan.greer@evan.greer>
Co-authored-by: Evan Greer <evan.greer@evan.greer>
Co-authored-by: Evan Greer <evan.greer@evan.greer>
…etes" This reverts commit 62bcd84.
Co-authored-by: Evan Greer <evan.greer@evan.greer>
evantk91
changed the title
joaodordio
requested changes
Aug 19, 2025
| ).onSuccess { _ in | ||
| ITBInfo("Pending consent tracked successfully") | ||
| }.onError { error in | ||
| ITBError("Failed to track pending consent: \(error)") |
There was a problem hiding this comment.
Like we have discussed, it would be good to have a retry mechanism here that tries to track the consent a second time and then fails definitely.
| } | ||
|
|
||
| // Clear the pending consent data | ||
| pendingConsentData = nil |
There was a problem hiding this comment.
Would be good to call the clearPendingConsent() method here instead.
sumeruchat
added
the
BCIT-PUSH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description