-
Notifications
You must be signed in to change notification settings - Fork 39
Initial CodeQL commit #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
4b57564
Initial CodeQL commit
noelle-iterable bfbe3b8
changing swift build mode to manual
randall-wyatt 387fae6
working on the artifact for ios
randall-wyatt 07dd54a
working on the artifact for ios
randall-wyatt c778ac3
Working on the artifact for iOS v2
noelle-iterable 7824467
Checking to see if the failure is due to a poorly configured turbo.js…
noelle-iterable 683fa7a
Fixed yml config error in hierarchy
noelle-iterable fb7391f
Setting timeout for build
noelle-iterable bf2ec60
Debugging cache settings
noelle-iterable f92a213
Looks like it was cancelled before it could complete, extending timeout
noelle-iterable 560b97f
ignoring kotlin files that will not build in this environment
noelle-iterable c7a46b0
Using the path-ignore doesn't work for compiled langauges. isolating …
noelle-iterable f38d0a3
re-declaring permissions and strategy
noelle-iterable c6d9f53
Changing how CocoaPod dependencies are called
noelle-iterable a628773
filtering out the autobuild java and kt results
noelle-iterable c656ca9
Seems like there is a number of files that cannot be found and the ca…
noelle-iterable fbeaeee
Testing instal of react native sdk inline with the ios example build
noelle-iterable e71e649
Testing instal of react native sdk inline with the ios example build,…
noelle-iterable 1a2bbd7
Testing instal of react native sdk inline with the ios example build,…
noelle-iterable f3a251c
Testing another variant of build for iOS
noelle-iterable 65fbfe7
using the correct code path
noelle-iterable a7a0d11
Code path not found, going back to default path
noelle-iterable 3e1647f
Resolving peer dependency issue
noelle-iterable 7119966
Changing to manual build
noelle-iterable 619a886
Changing to manual build and updating build steps to include xcode bu…
noelle-iterable d622f24
Fixing some yml issues
noelle-iterable 7b25738
Fixing some yml more yml issues
noelle-iterable cdca923
Trying again with manual build steps
noelle-iterable 62914f6
Using project instead of workspace to build manually
noelle-iterable 7298ff8
output project scheme before attempting to build
noelle-iterable 1c3a65e
yaml formatting issues
noelle-iterable 3f8edca
yaml formatting issues again
noelle-iterable 219fc64
trying to build with another scheme
noelle-iterable 2d98553
Saw an error about not being able to access the schema/project if som…
noelle-iterable 545f90a
I hate yaml
noelle-iterable b09aa88
I hate yaml, wrong order of declaration for setting up xcode
noelle-iterable 08d1c2d
list schemes before trying to build
noelle-iterable f25ea2b
changing the scheme again
noelle-iterable be12b84
trying to get it to list the available info for xcode build
noelle-iterable 896e8e8
changed from workspace to project
noelle-iterable 2fc5562
removing comments from command line operations
noelle-iterable 74a37e9
Fixing typo in the file name for the project
noelle-iterable 3d8013f
trying to fix the build output.
noelle-iterable 6c8129a
trying to fix build. removing some of the options.
noelle-iterable d4f64ec
trying to fix build. had some conflicting settings
noelle-iterable d437686
trying to fix build. no simulator.
noelle-iterable 1d60ad6
Maybe some kind of conflict between macos-15 and latest?
noelle-iterable 047b372
Thank you for being so easy to debug.
noelle-iterable 5675776
tweaking the iphone dev target version.
noelle-iterable 50fd797
trying to verify that the architechture isn't messing with the build
noelle-iterable 14b8d18
trying to do a clean before the build.
noelle-iterable 8bb4a39
trying to do a clean before the build without using bash to run the c…
noelle-iterable d59d791
changing the sdk to iphoneos13.2
noelle-iterable 6029f2f
changing the sdk back to just iphoneos
noelle-iterable 21167cd
fiddling with the build config again. removing a few things.
noelle-iterable 5f021c7
i still hate yml
noelle-iterable 4d67a2b
modified some build settings and set continue on error to true
noelle-iterable 61d9fbe
moving manual build steps to under the analyze with codeql steps.
noelle-iterable e5cfb61
moving manual build steps to under the analyze with codeql steps with…
noelle-iterable 730d421
putting the build step between init and analyze
noelle-iterable 99372eb
swift version mismatch?
noelle-iterable b9fcf37
swift version mismatch 6.0 => 5.9
noelle-iterable 58c7b0c
reactnativedependencies build fail fix
noelle-iterable 15036a8
react native binary doesn't get saved.
noelle-iterable 04bad05
switching back to manual build inside the init state.
noelle-iterable 50d2b44
switching back to manual build inside the init state and commenting o…
noelle-iterable 991e9a3
refining manual steps for building the project
noelle-iterable 98de609
I can't call codeql inside the run script.
noelle-iterable 606e043
building manual inside of the init did not work at all and codeql fai…
noelle-iterable 47567b0
turned code signing back off.
noelle-iterable 13fe939
still debugging...
noelle-iterable 5e93de8
does workspace also fail?
noelle-iterable e0526e4
changing to a build mode that seems to have worked at some point
noelle-iterable 65c1241
example app installs, but has no code, so fail.
noelle-iterable f19f3d7
breaking clean into it's own step didn't work
noelle-iterable 70ba8b9
use modular headers?
noelle-iterable b711179
use modular headers in podfile
noelle-iterable 7048257
use modular headers in podfile, wrong location.
noelle-iterable bdce427
hermes enabled in podfile
noelle-iterable 33f76a7
added @react-native-community/cli to build example for ios
noelle-iterable 36e97ad
trying to use the build after codeql init
noelle-iterable 4fa2162
running code build separately.
noelle-iterable db2e93c
fixing error with RNIterableAPI access
noelle-iterable 4cd8afc
Enabling hermes and fabric
noelle-iterable 8882ca9
Enabling hermes and fabric changed config
noelle-iterable 3e718d9
Enabling hermes and fabric changed config, a different podfile config…
noelle-iterable 7369caf
Enabling hermes and fabric changed config, a different podfile config…
noelle-iterable 10bb2f3
seeing if the build works from the project perspective
noelle-iterable 6823001
changing back to workspace.
noelle-iterable 2d8550a
attempting to use the command line from packaage.json
noelle-iterable fab7e5a
trying to use react to build-ios
noelle-iterable 6388dad
trying to use react to build-ios, fixing typo
noelle-iterable 3e7ad7a
heckin' heck. community cli replaced the old one. need to fix this gl…
noelle-iterable 33049ee
this is borked to all hell
noelle-iterable 3bd2226
looks like the command from the package.json doesn't work because of …
noelle-iterable 417c470
looks like the command from the package.json doesn't work because of …
noelle-iterable 74a4a41
switching back to manual build
noelle-iterable 60299d0
switching back to manual build, and removing the separate step.
noelle-iterable 2c70e28
so close...
noelle-iterable 078e6c7
so close... pulling the sarif-results
noelle-iterable b9f8e70
checking to see if the same works targeting the rniterableapi
noelle-iterable d211672
This builds and analyzes the Example app, which includes the RNIterab…
noelle-iterable e2b91c8
This builds and analyzes the Example app, which includes the RNIterab…
noelle-iterable 9c5d58a
This builds and analyzes the Example app, which includes the RNIterab…
noelle-iterable 17108a7
trying to turn flipper off without modify the Podfile
noelle-iterable d29cff6
Modifying codeql.yml to fix build issue
noelle-iterable f4d1d25
Modifying codeql.yml to fix build issue, wrong path
noelle-iterable 32e3211
Modifying codeql.yml to fix build issue, wrong path, typo.
noelle-iterable 5d49da8
Modifying codeql.yml to fix build issue, pod install broke.
noelle-iterable c98b68f
android example build steps
noelle-iterable 40a393a
android example build with yarn
noelle-iterable 2c9f6ec
android example build with yarn, stupid typo
noelle-iterable 499299d
android is choaking on a typescript, new ios instructions
noelle-iterable 531b062
android is choaking on a typescript, new ios instructions changed fro…
noelle-iterable 20fe2a8
the steps didn't seem to work out, going back to loren's steps
noelle-iterable 6a2c598
complained about bundle exec by itself
noelle-iterable a356b07
complained about a depenency, tryingto just do a pod install
noelle-iterable 4c44703
did not build the example app. made changes to the android script.
noelle-iterable 89a2900
android is working now, ios seems to stall out building
noelle-iterable 506265e
out of date dependency, doesn't perform the full install for ios
noelle-iterable eea36d6
out of date dependency, doesn't perform the full install for ios v2
noelle-iterable 1d9c1f5
I think this is a final.
noelle-iterable 961f164
Incorporating comments from lposen
noelle-iterable 360a41b
Changing the build command for ios, changed the gradle command back t…
noelle-iterable 56ecc9d
Build for Android succeeds on clean, doublechecking build. ios build …
noelle-iterable 48d24e9
Cleaned up the build steps so that the codeql database is populated a…
noelle-iterable File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,214 @@ | ||
# For most projects, this workflow file will not need changing; you simply need | ||
# to commit it to your repository. | ||
# | ||
# You may wish to alter this file to override the set of languages analyzed, | ||
# or to provide custom queries or build logic. | ||
# | ||
# ******** NOTE ******** | ||
# We have attempted to detect the languages in your repository. Please check | ||
# the `language` matrix defined below to confirm you have the correct set of | ||
# supported CodeQL languages. | ||
# | ||
name: "CodeQL Advanced" | ||
|
||
on: | ||
push: | ||
branches: [ "master" ] | ||
pull_request: | ||
branches: [ "master" ] | ||
|
||
jobs: | ||
Analyze_Ruby_JSandTS: | ||
name: Analyze (${{ matrix.language }}) | ||
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||
permissions: | ||
# required for all workflows | ||
security-events: write | ||
|
||
# required to fetch internal or private CodeQL packs | ||
packages: read | ||
|
||
# only required for workflows in private repositories | ||
actions: read | ||
contents: read | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- language: actions | ||
build-mode: none | ||
- language: javascript-typescript | ||
build-mode: none | ||
- language: ruby | ||
build-mode: none | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
# Add any setup steps before running the `github/codeql-action/init` action. | ||
# This includes steps like installing compilers or runtimes (`actions/setup-node` | ||
# or others). This is typically only required for manual builds. | ||
# - name: Setup runtime (example) | ||
# uses: actions/setup-example@v1 | ||
|
||
# Initializes the CodeQL tools for scanning. | ||
- name: Initialize CodeQL | ||
uses: github/codeql-action/init@v3 | ||
with: | ||
languages: ${{ matrix.language }} | ||
build-mode: ${{ matrix.build-mode }} | ||
# If you wish to specify custom queries, you can do so here or in a config file. | ||
# By default, queries listed here will override any specified in a config file. | ||
# Prefix the list here with "+" to use these queries and those in the config file. | ||
|
||
# For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
queries: ${{ matrix.language && 'security-extended, security-and-quality' }} | ||
|
||
- if: matrix.build-mode == 'manual' | ||
shell: bash | ||
run: | | ||
echo 'If you are using a "manual" build mode for one or more of the' \ | ||
'languages you are analyzing, replace this with the commands to build' \ | ||
'your code, for example:' | ||
echo ' make bootstrap' | ||
echo ' make release' | ||
exit 1 | ||
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v3 | ||
with: | ||
category: "/language:${{matrix.language}}" | ||
|
||
Build_Analyze_Android_Example: | ||
name: Analyze (${{ matrix.language }}) | ||
runs-on: ubuntu-latest | ||
env: | ||
TURBO_CACHE_DIR: .turbo/android | ||
permissions: | ||
# required for all workflows | ||
security-events: write | ||
|
||
# required to fetch internal or private CodeQL packs | ||
packages: read | ||
|
||
# only required for workflows in private repositories | ||
actions: read | ||
contents: read | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- language: java-kotlin | ||
build-mode: manual | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
# Add any setup steps before running the `github/codeql-action/init` action. | ||
# This includes steps like installing compilers or runtimes (`actions/setup-node` | ||
# or others). This is typically only required for manual builds. | ||
# - name: Setup runtime (example) | ||
# uses: actions/setup-example@v1 | ||
|
||
- name: Setup | ||
uses: ./.github/actions/setup | ||
|
||
- name: Install JDK | ||
if: env.turbo_cache_hit != 1 | ||
uses: actions/setup-java@v3 | ||
with: | ||
distribution: 'zulu' | ||
java-version: '17' | ||
|
||
- name: Finalize Android SDK | ||
if: env.turbo_cache_hit !=1 | ||
run: | | ||
/bin/bash -c "yes | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --licenses > /dev/null" | ||
|
||
# Initializes the CodeQL tools for scanning. | ||
- name: Initialize CodeQL | ||
uses: github/codeql-action/init@v3 | ||
with: | ||
languages: ${{ matrix.language }} | ||
build-mode: ${{ matrix.build-mode }} | ||
# If you wish to specify custom queries, you can do so here or in a config file. | ||
# By default, queries listed here will override any specified in a config file. | ||
# Prefix the list here with "+" to use these queries and those in the config file. | ||
|
||
# For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
queries: ${{ matrix.language && 'security-extended, security-and-quality' }} | ||
|
||
- if: matrix.build-mode == 'manual' | ||
shell: bash | ||
run: | | ||
cd example | ||
yarn install | ||
cd android | ||
./gradlew clean | ||
|
||
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v3 | ||
with: | ||
category: "/language:${{matrix.language}}" | ||
|
||
Build_Analyze_iOS_Example: | ||
name: Analyze (${{ matrix.language }}) | ||
timeout-minutes: 120 | ||
env: | ||
TURBO_CACHE_DIR: .turbo/ios | ||
TURBO_TOKEN: ${{ secrets. TURBO_TOKEN }} | ||
TURBO_TEAM: ${{ secrets. TURBO_TEAM }} | ||
|
||
runs-on: ${{ (matrix.language == 'swift' && 'macos-15') || 'ubuntu-latest' }} | ||
permissions: | ||
# required for all workflows | ||
security-events: write | ||
# required to fetch internal or private CodeQL packs | ||
packages: read | ||
# only required for workflows in private repositories | ||
actions: read | ||
contents: read | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- language: swift | ||
build-mode: manual | ||
|
||
steps: | ||
- name: Checkout react-native-sdk | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup | ||
uses: ./.github/actions/setup | ||
|
||
# Initializes the CodeQL tools for scanning. | ||
- name: Initialize CodeQL | ||
uses: github/codeql-action/init@v3 | ||
with: | ||
languages: ${{ matrix.language }} | ||
build-mode: ${{ matrix.build-mode }} | ||
# If you wish to specify custom queries, you can do so here or in a config file. | ||
# By default, queries listed here will override any specified in a config file. | ||
# Prefix the list here with "+" to use these queries and those in the config file. | ||
|
||
# For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
queries: ${{ matrix.language && 'security-extended, security-and-quality' }} | ||
|
||
- if: matrix.build-mode == 'manual' | ||
shell: bash | ||
run: | | ||
noelle-iterable marked this conversation as resolved.
Show resolved
Hide resolved
|
||
cd example | ||
yarn install | ||
cd ios | ||
bundle install | ||
bundle exec pod install | ||
xcodebuild -workspace ReactNativeSdkExample.xcworkspace -scheme ReactNativeSdkExample -configuration Debug -destination 'platform=iOS Simulator,name=iPhone 16' build | ||
|
||
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v3 | ||
with: | ||
category: "/language:${{matrix.language}}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ | |
"!example/ios/build", | ||
"!example/ios/Pods" | ||
], | ||
"outputs": [] | ||
"outputs": [".turbo/cache"] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.