Skip to content

Jwt/all #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: new-arch/master
Choose a base branch
from
Draft

Jwt/all #721

wants to merge 12 commits into from

Conversation

lposen
Copy link
Contributor

@lposen lposen commented Oct 6, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

lposen added 10 commits October 3, 2025 17:21
@lposen
chore: update Iterable API dependency to version 3.5.10 and add onAut…
80d67f6 
…hFailure event handling
@lposen
feat: implement onAuthFailure method in RNIterableAPIModule for new a…
3cb5d4c 
…rchitecture
@lposen
feat: enhance auth failure handling with detailed error reporting and…
f82e23b 
… new enum for failure reasons
@lposen
feat: add retry policy configuration to Iterable SDK with linear and …
8d01321 
…exponential backoff options
@lposen
feat: implement handling of auth failure
8ade24d
@lposen
chore: update Iterable-iOS-SDK dependency to version 6.6.1
ab554a1
@lposen
feat: add pauseAuthRetries method to RNIterableAPIModule for both arc…
70dbbc2 
…hitectures
@lposen
feat: refactor pauseAuthRetries method in ReactIterableAPI to use Ite…
e6e821e 
…rableAPI directly
@lposen
feat: add TODO.md file outlining new Iterable API features and config…
0470f8e 
…urations
@lposen
feat: enhance AppDelegate
d8cb608
@qltysh qltysh
Copy link

qltysh bot commented Oct 6, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will not change total coverage.

File Coverage Changes
Path File Coverage Δ Indirect
src/core/enums/IterableAuthFailureReason.ts 100.0
src/core/enums/IterableRetryBackoff.ts 100.0
src/core/types/IterableAuthFailure.ts 100.0
src/core/types/IterableRetryPolicy.ts 100.0
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

Lines Statements Branches Functions
Coverage: 47%
 47.34% (223/471) 22.04% (41/186) 40.38% (63/156)

@qltysh qltysh
Copy link

qltysh bot commented Oct 6, 2025 •
edited
Loading

2 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 6): setupUserNotificationCenter 1
qlty Structure Function with many returns (count = 8): IterableAppProvider 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

qltysh[bot]
qltysh bot reviewed Oct 6, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Oct 7, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Oct 9, 2025
View reviewed changes
example/ios/ReactNativeSdkExample/AppDelegate.swift
Comment on lines +88 to +110
private func setupUserNotificationCenter() {
UNUserNotificationCenter.current().delegate = self
UNUserNotificationCenter.current().getNotificationSettings { settings in
if settings.authorizationStatus != .authorized {
ITBInfo("Not authorized")
// not authorized, ask for permission
UNUserNotificationCenter.current().requestAuthorization(options: [.alert, .badge, .sound]) { success, _ in
ITBInfo("auth: \(success)")
if success {
DispatchQueue.main.async {
UIApplication.shared.registerForRemoteNotifications()
}
}
// TODO: Handle error etc.
}
} else {
// already authorized
ITBInfo("Already authorized")
DispatchQueue.main.async {
UIApplication.shared.registerForRemoteNotifications()
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 6): setupUserNotificationCenter [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lposen