Align API names with Twitch reference, fix pagination deserialization#58
Merged
Its-donkey merged 2 commits intotestfrom Feb 10, 2026
Merged
Align API names with Twitch reference, fix pagination deserialization#58Its-donkey merged 2 commits intotestfrom
Its-donkey merged 2 commits intotestfrom
Conversation
Rename functions to match official Twitch API endpoint names: - GetCustomRewards → GetCustomReward - GetCustomRewardRedemptions → GetCustomRewardRedemption - GetCharityDonations → GetCharityCampaignDonations - AddSuspiciousUserStatus → AddSuspiciousStatusToChatUser - RemoveSuspiciousUserStatus → RemoveSuspiciousStatusFromChatUser Update GetCharityCampaign to accept GetCharityCampaignParams with pagination support and return *Response[CharityCampaign] for consistency with other endpoints. Add custom Pagination.UnmarshalJSON to handle Twitch endpoints that return pagination as an empty string instead of an object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCustomReward,GetCustomRewardRedemption,GetCharityCampaignDonations,AddSuspiciousStatusToChatUser,RemoveSuspiciousStatusFromChatUserGetCharityCampaignto accept*GetCharityCampaignParams(with pagination) and return*Response[CharityCampaign]for consistency"pagination": ""instead of{"cursor": "..."}(e.g. Get Extension Live Channels)Breaking Changes
All renames include corresponding params types. See CHANGELOG for full details.
Testing
TestClient_GetCharityCampaign_Pagination,TestClient_GetExtensionLiveChannels_StringPaginationstaticcheckclean