Hook double output filter insert fix plus logging enhancements #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking to bypass sleeping if client's bandwidth is already less than available.
…acking to bypass sleeping if client's bandwidth is already less than available.
… calcuations to avoid sleeping if client bandwidth is less than available.
…ub.com/sosherof/mod_bw into fixes_for_windows_and_client_bandwidth
…ff than there actually are. Reverted some of these.Removed math.h include that wasn't needed.
…ub.com/sosherof/mod_bw into fixes_for_windows_and_client_bandwidth
* Simplified the client_bw math such that sleep time is simply added to the interval start time instead of tracked separately and mathed later. Why not save a variable and some math overhead.
…Made some logging enhancements.
…ment so logs will contain module name and module level logging can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where another module that creates subrequests, such as mod_xsendfile, causes the hook handler to insert the output filter twice. Enhanced the debug logs to display sizes and rates in human-readable format.