bumped f4enix version and fixed compatibility#484
Conversation
WalkthroughBumps f4enix to >=0.19.0, updates Nuclide import to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 25: The dependency constraint for f4enix in pyproject.toml is
unsatisfiable (f4enix >= 0.19.0); update the f4enix requirement to a released
version such as "f4enix >= 0.18.1" or a bounded range like "f4enix >= 0.18.1, <
0.20.0" in the dependencies list, or if 0.19.0 is intentionally required,
document/justify that it’s a pre-release and point to where it can be obtained;
update the f4enix entry accordingly so installations succeed.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/pytest.yml (1)
65-67: Clarify the 3.11 legacy step label/comment for CI readability.Two steps share the same name (
Install openmc (legacy)), which makes job logs harder to scan, and the comment says “python 11” instead of “python 3.11”.Proposed tweak
- # Cap version also for python 11 - - name: Install openmc (legacy) + # Cap version also for python 3.11 + - name: Install openmc (legacy, py3.11)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pytest.yml around lines 65 - 67, The CI step label and comment are ambiguous: change the comment text from "python 11" to "python 3.11" and give the step name "Install openmc (legacy)" a unique, descriptive name (e.g., "Install openmc (legacy, py3.11)") so logs are easier to scan; update the step name referenced in the workflow and any matching conditionals (matrix.python-version == '3.11') accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pytest.yml:
- Around line 65-67: The CI step label and comment are ambiguous: change the
comment text from "python 11" to "python 3.11" and give the step name "Install
openmc (legacy)" a unique, descriptive name (e.g., "Install openmc (legacy,
py3.11)") so logs are easier to scan; update the step name referenced in the
workflow and any matching conditionals (matrix.python-version == '3.11')
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: db218a02-11f4-4b16-ac22-c8e206ea9fea
📒 Files selected for processing (1)
.github/workflows/pytest.yml
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/pytest.yml (1)
65-67: Disambiguate the legacy step name and fix the version typo.Line 65 says “python 11”, and Line 66 reuses the same step name as the 3.10 legacy step. This makes CI logs harder to read during failures. Please rename this step to include
3.11and correct the comment text.Suggested tweak
- # Cap version also for python 11 - - name: Install openmc (legacy) + # Cap version also for python 3.11 + - name: Install openmc (legacy, py3.11)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pytest.yml around lines 65 - 67, Update the comment and the step name to correctly reference Python 3.11: change the comment "Cap version also for python 11" to "Cap version also for python 3.11" and disambiguate the step by renaming the step labeled "Install openmc (legacy)" for the 3.11 case to something like "Install openmc (legacy, 3.11)" so it no longer duplicates the 3.10 step name; ensure the if condition remains using matrix.python-version == '3.11' to match the corrected text.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pytest.yml:
- Around line 65-67: Update the comment and the step name to correctly reference
Python 3.11: change the comment "Cap version also for python 11" to "Cap version
also for python 3.11" and disambiguate the step by renaming the step labeled
"Install openmc (legacy)" for the 3.11 case to something like "Install openmc
(legacy, 3.11)" so it no longer duplicates the 3.10 step name; ensure the if
condition remains using matrix.python-version == '3.11' to match the corrected
text.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d4ec61b5-7ca9-412f-bde3-5b4a0a2a90c9
📒 Files selected for processing (1)
.github/workflows/pytest.yml
|
Had to fix a version for openMC and python 3.11 since in dev branch support for python 3.11 has been dropped, ready for review now @alexvalentine94 |
1 participant
Bump F4Enix version to 0.19.0
Summary by CodeRabbit
Chores
Refactor