Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
cgiovanetti
left a comment
There was a problem hiding this comment.
Looks great, sounds like we could also kill polylog/Li if we implement this? I'd prefer that since scipy.special doesn't have polylog.
|
@cgiovanetti personally, I think it's okay to have things that don't have a direct scipy equivalent, and it is documented as such. Do you use polylog with |
|
I'll add some tests into https://github.com/JAXtronomy/spexial/tree/main/tests/regression matching what is done for gegenbauer. |
Yeah, we do allow all |
This is an implementation I have of
scipy.special.spencefor complex input.jax.scipy.specialimplements the function for real inputs.This has significant over lap with
polylog/Libut matches the scipy API more closely (scipy uses a slightly unusual definition). The current implementationLigives the generic polylogarithm while this should matchThere are also some differences for complex inputs and I think this implementation matches
scipybetter, for example