Conversation
|
@CoryMartin-NOAA @EdwardSafford-NOAA The changes to the map gridded plot are due to some tests inputting 1D lat/lon data and then looking for 3D data (i.e levels, lat, lon). So I had to add a bandaid that essentially rewrites data to 2D so the changes in EMCPy don't break. It has to do with how the plotting handles the cell centers and edges. |
There was a problem hiding this comment.
Pull Request Overview
Updates EMCPy dependency hashes across all requirement files and refactors the EMCPy map gridded plotting to handle various grid configurations more robustly.
- Updates EMCPy git hash to
7794574611e760475d61eb5d9458af2d3d2191d8in all requirement files - Replaces the EMCPy map gridded plotting implementation with comprehensive handling for 1-D, 2-D, and 3-D grid configurations
- Adds robust data normalization logic to convert various input formats to the 2-D centers required by EMCPy
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/eva/plotting/batch/emcpy/diagnostics/emcpy_map_gridded.py | Complete rewrite of EMCPy map gridded plotting with enhanced grid handling and data normalization |
| requirements_sles15.txt | Updates EMCPy git hash dependency |
| requirements-github.txt | Updates EMCPy git hash dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@CoryMartin-NOAA Do you mind taking a look at this? |
Description
In my last PR, I only updated one requirement file for the new EMCPy hash. I believe I need to update them all.
Alos had to make adjustments to how eva handled the EMCPy map gridded plotting. All tests are passing as expected.