Skip to content

bufr_query: add v0.0.5 (upstream spack-packages #3011) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 1 commit into from
Jan 14, 2026
Merged

bufr_query: add v0.0.5 (upstream spack-packages #3011) #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions repos/spack_repo/builtin/packages/bufr_query/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,16 @@ class BufrQuery(CMakePackage, PythonExtension):

license("Apache-2.0", checked_by="srherbener")

version("0.0.5", sha256="72cb82d3837aac0dbe2c514b9883b4a19aad2ab7c6969c760e1b549ab4ed4831")
version("0.0.4", sha256="cc21a298c03ee3a8938823301606e91c7b321005da284ebf2c9b25044bfcbad8")
version("0.0.3", sha256="f2952a190cc1d7714a3bfe481fb1545459639ba304fc31b941062b471dea1d41")
version("0.0.2", sha256="b87a128246e79e3c76e3158d89823e2ae38e9ee1a5a81b6f7b423837bdb93a1f")
version("0.0.1", sha256="001990d864533c101b93d1c351edf50cf8b5ccc575e442d174735f6c332d3d03")

depends_on("c", type="build")
depends_on("cxx", type="build")
depends_on("fortran", type="build")

# Required dependencies
depends_on("ecbuild", type=("build"))
depends_on("llvm-openmp", when="%apple-clang", type=("build", "run"))
Expand All @@ -33,6 +38,9 @@ class BufrQuery(CMakePackage, PythonExtension):
depends_on("eigen@3:", type=("build", "run"))
depends_on("gsl-lite", type=("build", "run"))
depends_on("netcdf-c", type=("build", "run"))
# bufr-query versions up to 0.0.4 are incompatible with netcdf-c 4.9.3 and later
# https://github.com/NOAA-EMC/bufr-query/issues/58
depends_on("netcdf-c@:4.9.2", when="@:0.0.4", type=("build", "run"))
depends_on("netcdf-cxx4", type=("build", "run"))
depends_on("bufr", type=("build", "run"))

Expand All @@ -42,6 +50,8 @@ class BufrQuery(CMakePackage, PythonExtension):
with when("+python"):
extends("python")
depends_on("py-pybind11", type="build")
# with 0.0.5, we should also add py-wxflow as a dependency
depends_on("py-wxflow", type="build", when="@0.0.5:")

# Patches
patch(
Expand All @@ -54,9 +64,18 @@ class BufrQuery(CMakePackage, PythonExtension):
def cmake_args(self):
args = [self.define_from_variant("BUILD_PYTHON_BINDINGS", "python")]

# provide path to netcdf-c include files
nc_include_dir = Executable("nc-config")("--includedir", output=str).strip()
args.append("-DCMAKE_C_FLAGS=-I" + nc_include_dir)
args.append("-DCMAKE_CXX_FLAGS=-I" + nc_include_dir)
# Join the include directories from both netcdf-c and netcdf-cxx4
# Spack's .headers.include_flags produces strings like "-I/path/to/inc"
nc_includes = self.spec["netcdf-c"].headers.include_flags
ncxx_includes = self.spec["netcdf-cxx4"].headers.include_flags

combined_flags = f"{nc_includes} {ncxx_includes}"

args.extend(
[
self.define("CMAKE_C_FLAGS", combined_flags),
self.define("CMAKE_CXX_FLAGS", combined_flags),
]
)

return args