Bug fix for building pixman with meson builder (find libpng)#35
Merged
climbfuji merged 2 commits intoJCSDA:spack-stack-devfrom Jan 14, 2026
Merged
Conversation
…when build system is meson to find libpng
13 tasks
…in/packages/pixman/package.py
climbfuji
requested review from
AlexanderRichert-NOAA,
eap,
mathomp4 and
rickgrubin-noaa
rickgrubin-noaa
approved these changes
Jan 14, 2026
Collaborator
Author
|
@AlexanderRichert-NOAA approved these changes in the upstream spack-packages repo (PR got merged there), and CI tests passed for spack-stack. With @rickgrubin-noaa's additional approval, I can merge this. |
github-project-automation
bot
moved this from In Progress
to Done
in spack-stack-2.1.x (2026 Q1)
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add repos/spack_repo/builtin/packages/pixman/libpng.patch for pixman when build system is meson to find libpng
See spack#3032 for more information, and spack#3033 for an upstream PR of these changes and additional changes for static pixman builds that aren't in the upstream repo yet.
Testing
See JCSDA/spack-stack#1877