-
Notifications
You must be signed in to change notification settings - Fork 55
[skip ci] Updates for spack v1 at NAS #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mathomp4
wants to merge
9
commits into
JCSDA:feature/update_to_spack_v1
Choose a base branch
from
mathomp4:feature/nas_install_spack_v1
base: feature/update_to_spack_v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[skip ci] Updates for spack v1 at NAS #1810
mathomp4
wants to merge
9
commits into
JCSDA:feature/update_to_spack_v1
from
mathomp4:feature/nas_install_spack_v1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Nov 10, 2025
Collaborator
Author
|
@climbfuji Many a change pushed based on your suggestions. Please take another look. |
climbfuji
approved these changes
Nov 14, 2025
repos/spack_stack/spack_repo/spack_stack/packages/gmao_swell_env/package.py
Outdated
Show resolved
Hide resolved
Collaborator
|
@mathomp4 Do you want to merge this as is and do the spack package updates in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has updates for spack-stack v2 at NAS.
Beyond the updates for the machine itself, I'm also trying to close #1139 and build FMS in two ways with both GFS and GEOS constants.
At the moment, both variants do build, but weirdly I only get a suffix in the modulefiles for GFS→ This is no longer true. Was a typo on my end.The other issue with this is that I'm not sure how to handle the spack-stack unique modules. When I build this, the fms versions are all wonky. To be "safe" only the GEOS important ones should probably default to
constants=GEOSFMS, things likejedi-geos-envandgeos-gcm-env(which at the moment have internal FMS, but soon will not). I'm not sure how to make these default toconstants=GFS. I mean...some did...Dependencies
I will need to make a PR to spack-packages for some package updates I need. I'll work with @climbfuji or @AlexanderRichert-NOAA to teach me the right way to do this. I'm not the best at submodules
Issues addressed
Closes #1139
Applications affected
I guess
ufs-weather-model-env,ufs-srw-app-envandjedi-ufs-envare now picking up the wrong FMS. Nuts.Also, I updated
geos-gcm-envandjedi-geos-envtoesmf@8.9.0because we use that now.Systems affected
NAS directly.
In trying to look at #1139, all other systems?
Testing
Checklist
doc/source/PreConfiguredSites.rstanddoc/source/MaintainersSection.rst