Skip to content

Conversation

@fmahebert
Copy link
Contributor

@fmahebert fmahebert commented Nov 10, 2025

Description

Update ECMWF's packages to the following versions,

ecbuild 3.12.0
eckit 1.32.3
fckit 0.14.1
fiat 1.6.1
ectrans 1.7.0
atlas 0.44.1

This is following the validation work of https://github.com/JCSDA-internal/oops/issues/3052

Dependencies

Issues addressed

Closes #1723

Applications affected

Impacts JEDI applications

Systems affected

Impacts all systems

Testing

  • CI:
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added:
  • Additional testing:

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

@climbfuji
Copy link
Collaborator

@fmahebert We need a PR for https://github.com/JCSDA/spack-packages that cherry-picks your commit(s) from spack/spack-packages#2366. Do you want me to create it and point your spack-stack PR to that branch?

@fmahebert fmahebert force-pushed the feature/new_atlas_and_dependency_versions branch from 5ac7dab to a411ba5 Compare November 17, 2025 19:29
@fmahebert fmahebert changed the base branch from develop to feature/update_to_spack_v1 November 17, 2025 19:29
@fmahebert
Copy link
Contributor Author

fmahebert commented Nov 17, 2025

@climbfuji

Please let me know if this is the correct configuration!

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the actual submodule pointer update here, just the .gitmodules update.

@fmahebert
Copy link
Contributor Author

Hopefully fixed...

@climbfuji
Copy link
Collaborator

Looks good now. We'll merge #1817 first, then update this PR, and wait for the CI tests to succeed.

@climbfuji
Copy link
Collaborator

Looks good now. We'll merge #1817 first, then update this PR, and wait for the CI tests to succeed.

Can you fix the merge conflicts, please? All that's needed is pulling in develop and "adding" (confirming) that the head of your current spack-packages branch is correct (because it is up to date with spack-stack-dev).

@climbfuji
Copy link
Collaborator

Looks good now. We'll merge #1817 first, then update this PR, and wait for the CI tests to succeed.

Can you fix the merge conflicts, please? All that's needed is pulling in develop and "adding" (confirming) that the head of your current spack-packages branch is correct (because it is up to date with spack-stack-dev).

Actually, I just merged JCSDA/spack-packages#22 - can you pull this into your spack-packages branch and update the submodule pointer while you are resolving the conflicts, please?

@fmahebert
Copy link
Contributor Author

Ahh, I was too fast / too slow! Yes, I will do that second step as well

@fmahebert
Copy link
Contributor Author

Done, hopefully correctly

@climbfuji
Copy link
Collaborator

@fmahebert I merged JCSDA/spack-packages#23, please update the spack-package submodule ptr to hash JCSDA/spack-packages@ea29f11 and revert the gitmodules change. Also, please pull in spack-stack develop once more, because we just merged #1821

@climbfuji climbfuji enabled auto-merge (squash) November 18, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[INSTALL]: atlas/0.43.0 or higher

2 participants