Skip to content

filesystem.py: prevent recursively traversing the root filesystem #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
climbfuji wants to merge 1 commit into
base: spack-stack-dev
Choose a base branch
from
+12 −0
Draft

filesystem.py: prevent recursively traversing the root filesystem #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/spack/spack/llnl/util/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,6 +1812,15 @@ def _dedupe_files(paths: List[str]) -> List[str]:
return unique_files


def _is_root_directory(curr_dir: str):
"""
Check if the given directory is the top-level root directory.
Works on Windows, macOS, and Linux.
"""
path = pathlib.Path(curr_dir).resolve()
return path == path.anchor or path.parent == path


def _find_max_depth(
roots: Sequence[Path], globs: Sequence[str], max_depth: int = sys.maxsize
) -> List[str]:
Expand Down Expand Up @@ -1846,6 +1855,9 @@ def _find_max_depth(

while dir_queue:
depth, curr_dir = dir_queue.pop()
# Never traverse root recursively
if _is_root_directory(curr_dir):
continue
try:
dir_iter = os.scandir(curr_dir)
except OSError as e:
Expand Down
Loading