Conversation
- Fix __delitem__: decrement _len, guard against intermediate nodes, clean up empty branches so paths can be reused as leaves - Fix __getitem__: raise KeyError(key) consistently rather than leaking internal branch/leaf details - Fix __setitem__: raise ValueError(key) for structural conflicts instead of KeyError, which is conventionally reserved for missing keys - Fix ConfigWidget.on_input_changed: use _id_to_field lookup for the key - Implement ConfigWidget.collect_config: start from model_dump() and apply changes at their correct nested paths before validating - Add tests for PathMapping covering all operations and edge cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace dots with hyphens in generated widget IDs; Textual only allows letters, numbers, underscores, and hyphens in identifiers - Pass the duplicate name to ValueError in new_tab so the error is informative rather than a bare raise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.