Skip to content

Rename FuturesApi GetFundingRate method to GetFundingRates#50

Merged
JKorf merged 2 commits intoJKorf:mainfrom
hmG3:fundingrates
Apr 1, 2026
Merged

Rename FuturesApi GetFundingRate method to GetFundingRates#50
JKorf merged 2 commits intoJKorf:mainfrom
hmG3:fundingrates

Conversation

@hmG3
Copy link
Copy Markdown
Contributor

@hmG3 hmG3 commented Mar 31, 2026

It is possible to fetch funding rates for all symbols at once.
I am suggesting introducing this breaking change to be consistent with other exchange libraries.

@hmG3 hmG3 marked this pull request as draft March 31, 2026 12:37
@hmG3
Copy link
Copy Markdown
Contributor Author

hmG3 commented Mar 31, 2026

@JKorf Need your input here.
api/v1/contract/funding_rate without symbol parameter returns data property as an array of items. But providing symbol, data property represents a single object. I think you already handled that somewhere in other libraries. Could you point out which pattern you used?

Btw, currently GetSymbolsAsync() fails with a deserialization exception when the symbol parameter is provided.

@JKorf
Copy link
Copy Markdown
Owner

JKorf commented Mar 31, 2026

Hi, I don't really have a preference for this. I've used seperate methods for it and also resolving it within a single method. However in this case I would go with the two seperate method since you can just leavet the existing one as it is and add the second method without symbol parameter.

@hmG3
Copy link
Copy Markdown
Contributor Author

hmG3 commented Mar 31, 2026

Ok, I went with a separate methods

@hmG3 hmG3 marked this pull request as ready for review March 31, 2026 16:00
@JKorf JKorf merged commit 04be442 into JKorf:main Apr 1, 2026
1 check passed
@hmG3 hmG3 deleted the fundingrates branch April 1, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants