Skip to content

Express back-end swap with Fastify#367

Open
Cold-A-Muse wants to merge 13 commits intodevfrom
feat/fastify-backend-impl
Open

Express back-end swap with Fastify#367
Cold-A-Muse wants to merge 13 commits intodevfrom
feat/fastify-backend-impl

Conversation

@Cold-A-Muse
Copy link
Collaborator

@Cold-A-Muse Cold-A-Muse commented Apr 1, 2022

First iteration of Fastify implementation
Replaced Express back-end with fastify back-end 🎉🎉🎉
Note: It is still using a fastify-express plugin to handle our previous express middleware. On their github page is stated:
This plugin should not be used as a long-term solution, it aims to help you have a smooth transition from Express to Fastify, but you should migrate your Express specific code to Fastify over time.

So in a next iteration we should probably swap them for native middleware.

Could you test your campaigner routes @JMitnik

Fixes HAAS-293

@Cold-A-Muse Cold-A-Muse requested a review from JMitnik April 4, 2022 05:36
@linear
Copy link

linear bot commented Apr 4, 2022

@JMitnik JMitnik changed the base branch from feat/dialogue-statistics-summary-initial to dev July 24, 2022 19:39
@Cold-A-Muse
Copy link
Collaborator Author

Cold-A-Muse commented Aug 5, 2022

Uploads of CSVs and workspace Logo work 🎉

I can't seem to login with this branch

RequestInvite gives me the following error {"data":null,"errors":[{"message":"Cannot read properties of undefined (reading 'slice')"}]}

  1. Assumption in code that either authorization header or access_token exists
  2. However for a 'fresh user' neither exists when running either requestInvite or verifyUserToken mutations (no authorization header needed) thus causing readBearerToken to fail (because it assumes auth header always exists when this part of the code is reached)
  3. After checking for undefined on this function it correctly sends out email. However, when I access the link it redirect me to 'your session has expired' page
  4. Auth (line 136) u should set access_token instead of refresh_token as cookie i think 🤔? This line doesn't actually seem to set any cookie at the moment cus the refresh_token is also not available in local storage after running this mutation

Strange re-renders

Re-renders are not smooth like in previous iterations
This branch: https://user-images.githubusercontent.com/5823083/183028322-7e5c07c7-4b93-474e-ae31-8695d02e5506.mov
Prev iteration:
https://user-images.githubusercontent.com/5823083/183028769-5313dfa4-729f-4f00-850b-664cb105caf2.mov

Note: Seems that the reset button flickering also happens on prod at the moment. The rest of less smooth transitions is probably just because it is super fast haha 😅

Submit + Cancel form buttons stacked

Instead of these form buttons being horizontally aligned they are stacked on top of each other.

Newly created question in Dialogue Builder is not shown in builder

image

This happens when there are two question entries within a branch who have the same match value (e.g. Facilities). Deleting the other entry with that option makes the newly created question visible

Note: This also currently happens on production.
Note 2: This doesn't happen when the root question is a slider question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants